Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1550)

Unified Diff: runtime/vm/intermediate_language.h

Issue 2149023002: VM: Array bounds checks that don't deoptimize for precompiled code. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: merge Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_type_propagator.cc ('k') | runtime/vm/intermediate_language_arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language.h
diff --git a/runtime/vm/intermediate_language.h b/runtime/vm/intermediate_language.h
index 7307344385661d950e42e516f05ba5c558cf60b5..bfcb8a767726f7262ab23fc717f2cc414d8a554f 100644
--- a/runtime/vm/intermediate_language.h
+++ b/runtime/vm/intermediate_language.h
@@ -512,6 +512,7 @@ class EmbeddedArray<T, 0> {
M(ShiftMintOp) \
M(UnaryMintOp) \
M(CheckArrayBound) \
+ M(GenericCheckBound) \
M(Constraint) \
M(StringToCharCode) \
M(OneByteStringFromCharCode) \
@@ -7928,6 +7929,35 @@ class CheckArrayBoundInstr : public TemplateInstruction<2, NoThrow, Pure> {
};
+class GenericCheckBoundInstr : public TemplateInstruction<2, Throws, NoCSE> {
+ public:
+ GenericCheckBoundInstr(Value* length, Value* index, intptr_t deopt_id)
+ : TemplateInstruction(deopt_id) {
+ SetInputAt(kLengthPos, length);
+ SetInputAt(kIndexPos, index);
+ }
+
+ Value* length() const { return inputs_[kLengthPos]; }
+ Value* index() const { return inputs_[kIndexPos]; }
+
+ virtual EffectSet Effects() const { return EffectSet::None(); }
+ virtual EffectSet Dependencies() const { return EffectSet::None(); }
+
+ DECLARE_INSTRUCTION(GenericCheckBound)
+
+ virtual bool CanDeoptimize() const { return true; }
+
+ // Give a name to the location/input indices.
+ enum {
+ kLengthPos = 0,
+ kIndexPos = 1
+ };
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(GenericCheckBoundInstr);
+};
+
+
class UnboxedIntConverterInstr : public TemplateDefinition<1, NoThrow> {
public:
UnboxedIntConverterInstr(Representation from,
« no previous file with comments | « runtime/vm/flow_graph_type_propagator.cc ('k') | runtime/vm/intermediate_language_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698