Allow multiple set_default calls in GN.

Allow multiple set_default calls in GN.

Allow multipe set_defaults calls in GN to override one another, and allow
imported .gni files with set_defaults calls in them to not collide with
existing defaults settings as long as the settings are the same.

This will allow us to be more flexible with defaults, in particular, to
allow the defaults for templates to move to the template declaration location
rather than having to reside in BUILDCONFIG.

Add an android condition around an android-specific config in base I noticed
when testing this patch.

BUG=627978
Committed: https://crrev.com/af8a964ba300ff17d304c982a0e98605c41637c5
Cr-Commit-Position: refs/heads/master@{#405539}

[brettw, 2016-07-13 21:34:26]

Description was changed from

==========
Allow multiple set_default calls in GN.

Allow multipe set_defaults calls in GN to override one another, and allow
imported .gni files with set_defaults calls in them to not collide with
existing defaults settings as long as the settings are the same.

This will allow us to be more flexible with defaults, in particular, to
allow the defaults for templates to move to the template declaration location
rather than having to reside in BUILDCONFIG.

BUG=627978
==========

to

==========
Allow multiple set_default calls in GN.

Allow multipe set_defaults calls in GN to override one another, and allow
imported .gni files with set_defaults calls in them to not collide with
existing defaults settings as long as the settings are the same.

This will allow us to be more flexible with defaults, in particular, to
allow the defaults for templates to move to the template declaration location
rather than having to reside in BUILDCONFIG.

Add an android condition around an android-specific config in base I noticed
when testing this patch.

BUG=627978
==========

[brettw, 2016-07-13 21:34:26]

brettw@chromium.org changed reviewers:
+ dpranke@chromium.org

[brettw, 2016-07-13 21:36:07]

.

[brettw, 2016-07-13 21:36:08]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 21:37:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 22:48:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 22:48:18]

Dry run: This issue passed the CQ dry run.

[brettw, 2016-07-14 17:31:08]

brettw@chromium.org changed reviewers:
+ brucedawson@chromium.org
- dpranke@chromium.org

[brettw, 2016-07-14 17:31:09]

->Bruce

[Dirk Pranke, 2016-07-14 19:13:26]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-07-14 19:13:27]

lgtm

[brettw, 2016-07-14 19:26:48]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-07-14 19:27:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 19:33:56]

Description was changed from

==========
Allow multiple set_default calls in GN.

Allow multipe set_defaults calls in GN to override one another, and allow
imported .gni files with set_defaults calls in them to not collide with
existing defaults settings as long as the settings are the same.

This will allow us to be more flexible with defaults, in particular, to
allow the defaults for templates to move to the template declaration location
rather than having to reside in BUILDCONFIG.

Add an android condition around an android-specific config in base I noticed
when testing this patch.

BUG=627978
==========

to

==========
Allow multiple set_default calls in GN.

Allow multipe set_defaults calls in GN to override one another, and allow
imported .gni files with set_defaults calls in them to not collide with
existing defaults settings as long as the settings are the same.

This will allow us to be more flexible with defaults, in particular, to
allow the defaults for templates to move to the template declaration location
rather than having to reside in BUILDCONFIG.

Add an android condition around an android-specific config in base I noticed
when testing this patch.

BUG=627978
==========

[commit-bot: I haz the power, 2016-07-14 19:33:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-14 19:34:00]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-14 19:35:41]

Description was changed from

==========
Allow multiple set_default calls in GN.

Allow multipe set_defaults calls in GN to override one another, and allow
imported .gni files with set_defaults calls in them to not collide with
existing defaults settings as long as the settings are the same.

This will allow us to be more flexible with defaults, in particular, to
allow the defaults for templates to move to the template declaration location
rather than having to reside in BUILDCONFIG.

Add an android condition around an android-specific config in base I noticed
when testing this patch.

BUG=627978
==========

to

==========
Allow multiple set_default calls in GN.

Allow multipe set_defaults calls in GN to override one another, and allow
imported .gni files with set_defaults calls in them to not collide with
existing defaults settings as long as the settings are the same.

This will allow us to be more flexible with defaults, in particular, to
allow the defaults for templates to move to the template declaration location
rather than having to reside in BUILDCONFIG.

Add an android condition around an android-specific config in base I noticed
when testing this patch.

BUG=627978

Committed: https://crrev.com/af8a964ba300ff17d304c982a0e98605c41637c5
Cr-Commit-Position: refs/heads/master@{#405539}
==========

[commit-bot: I haz the power, 2016-07-14 19:35:43]

Patchset 2 (id:??) landed as
https://crrev.com/af8a964ba300ff17d304c982a0e98605c41637c5
Cr-Commit-Position: refs/heads/master@{#405539}