Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Side by Side Diff: base/BUILD.gn

Issue 2148993002: Allow multiple set_default calls in GN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/gn/function_set_defaults.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # HOW TO WRITE CONDITIONALS IN THIS FILE 5 # HOW TO WRITE CONDITIONALS IN THIS FILE
6 # ====================================== 6 # ======================================
7 # 7 #
8 # In many other places, one would write a conditional that expresses all the 8 # In many other places, one would write a conditional that expresses all the
9 # cases when a source file is used or unused, and then either add or subtract 9 # cases when a source file is used or unused, and then either add or subtract
10 # it from the sources list in that case 10 # it from the sources list in that case
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 if (is_android || is_mac || is_ios) { 101 if (is_android || is_mac || is_ios) {
102 sources -= [ "base_paths_posix.cc" ] 102 sources -= [ "base_paths_posix.cc" ]
103 } 103 }
104 104
105 configs += [ ":base_implementation" ] 105 configs += [ ":base_implementation" ]
106 106
107 visibility = [ ":base" ] 107 visibility = [ ":base" ]
108 } 108 }
109 } 109 }
110 110
111 config("android_system_libs") { 111 if (is_android) {
112 libs = [ "log" ] # Used by logging.cc. 112 config("android_system_libs") {
113 libs = [ "log" ] # Used by logging.cc.
114 }
113 } 115 }
114 116
115 # Base and everything it depends on should be a static library rather than 117 # Base and everything it depends on should be a static library rather than
116 # a source set. Base is more of a "library" in the classic sense in that many 118 # a source set. Base is more of a "library" in the classic sense in that many
117 # small parts of it are used in many different contexts. This combined with a 119 # small parts of it are used in many different contexts. This combined with a
118 # few static initializers floating around means that dead code stripping 120 # few static initializers floating around means that dead code stripping
119 # still leaves a lot of code behind that isn't always used. For example, this 121 # still leaves a lot of code behind that isn't always used. For example, this
120 # saves more than 40K for a smaller target like chrome_elf. 122 # saves more than 40K for a smaller target like chrome_elf.
121 # 123 #
122 # Use static libraries for the helper stuff as well like //base/debug since 124 # Use static libraries for the helper stuff as well like //base/debug since
(...skipping 2305 matching lines...) Expand 10 before | Expand all | Expand 10 after
2428 2430
2429 # GYP: //base.gyp:base_java_unittest_support 2431 # GYP: //base.gyp:base_java_unittest_support
2430 android_library("base_java_unittest_support") { 2432 android_library("base_java_unittest_support") {
2431 deps = [ 2433 deps = [
2432 ":base_java", 2434 ":base_java",
2433 ] 2435 ]
2434 java_files = 2436 java_files =
2435 [ "test/android/java/src/org/chromium/base/ContentUriTestUtils.java" ] 2437 [ "test/android/java/src/org/chromium/base/ContentUriTestUtils.java" ]
2436 } 2438 }
2437 } 2439 }
OLDNEW
« no previous file with comments | « no previous file | tools/gn/function_set_defaults.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698