Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Issue 2148953002: mb: Remove a redundant mixin (Closed)

Created:
4 years, 5 months ago by Nico
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mb: Remove a redundant mixin no_pch and disable_precompiled_headers do the same thing; drop one of them. No behavior change. BUG=none Committed: https://crrev.com/97a65d535459ea44e713968fec9ff265a33dd4d7 Cr-Commit-Position: refs/heads/master@{#405245}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M tools/mb/mb_config.pyl View 2 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Nico
As mentioned on https://codereview.chromium.org/2151583002/diff/1/scripts/slave/recipes/win_analyze.expected/full_chromium_fyi_Chromium_Windows_Analyze.json#newcode137 I'm not sure if the analyze bot intentionally disables pch files ...
4 years, 5 months ago (2016-07-13 18:46:00 UTC) #2
Dirk Pranke
lgtm. I don't know if no_pch is actually required for sure. Bruce?
4 years, 5 months ago (2016-07-13 18:51:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2148953002/1
4 years, 5 months ago (2016-07-13 18:54:24 UTC) #5
brucedawson
On 2016/07/13 18:54:24, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 5 months ago (2016-07-13 19:25:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 19:57:46 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 19:58:08 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 20:00:15 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/97a65d535459ea44e713968fec9ff265a33dd4d7
Cr-Commit-Position: refs/heads/master@{#405245}

Powered by Google App Engine
This is Rietveld 408576698