Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(974)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/mb/mb_config.pyl

Issue 2148953002: mb: Remove a redundant mixin (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/mb/mb_config.pyl
diff --git a/tools/mb/mb_config.pyl b/tools/mb/mb_config.pyl
index c488acd563a433043682d2d44a4dd3eae839d270..ecf9e0bfcd01785517eb4012676fca41a917f967 100644
--- a/tools/mb/mb_config.pyl
+++ b/tools/mb/mb_config.pyl
@@ -1203,8 +1203,7 @@
],
'gn_windows_analyze': [
- 'gn', 'no_symbols', 'disable_precompiled_headers',
- 'shared', 'x86', 'win_analyze',
+ 'gn', 'no_symbols', 'no_pch', 'shared', 'x86', 'win_analyze',
],
'gn_ubsan_vptr_release_bot': [
@@ -2025,11 +2024,6 @@
'gyp_defines': 'disable_nacl=1',
},
- 'disable_precompiled_headers': {
- 'gn_args': 'disable_precompiled_headers=true',
- 'gyp_defines': 'chromium_win_pch=0',
- },
-
'edge': {
'gn_args': 'sanitizer_coverage_flags="edge"',
'gyp_defines': 'sanitizer_coverage=edge',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698