MacViews: Fixed CHECK in |-updateTooltipIfRequiredAt:|.

MacViews: Fixed CHECK in |-updateTooltipIfRequiredAt:|.

The CHECK was occured for menu widgets in MacViews browser.
When submenu appears above parent menu, parent menu widget get MouseExit
event with location in child menu widget.
View::ConvertPointToTarget works only if two views belongs to one widget
and does not fit for this case.

BUG=569447
Committed: https://crrev.com/5a484af29ce16842a03e9a7cfcb9f273722ac5ec
Cr-Commit-Position: refs/heads/master@{#405721}

[kirr, 2016-07-14 12:44:28]

Description was changed from

==========
MacViews: Fixed CHECK in |-updateTooltipIfRequiredAt:|.

The CHECK was occured for menu widgets in MacViews browser.
When submenu appears above parent menu, parent menu widget get MouseExit
event with location in child menu widget.
View::ConvertPointToTarget works only if two views belongs to one widget
and does not fit for this case.

BUG=569447
==========

to

==========
MacViews: Fixed CHECK in |-updateTooltipIfRequiredAt:|.

The CHECK was occured for menu widgets in MacViews browser.
When submenu appears above parent menu, parent menu widget get MouseExit
event with location in child menu widget.
View::ConvertPointToTarget works only if two views belongs to one widget
and does not fit for this case.

BUG=569447
==========

[kirr, 2016-07-14 12:44:28]

kirr@yandex-team.ru changed reviewers:
+ tapted@chromium.org

[tapted, 2016-07-15 06:23:45]

nice patch- thanks! ltgm % nits

https://codereview.chromium.org/2148893003/diff/1/ui/views/widget/native_widg...
File ui/views/widget/native_widget_mac_unittest.mm (right):

https://codereview.chromium.org/2148893003/diff/1/ui/views/widget/native_widg...
ui/views/widget/native_widget_mac_unittest.mm:265: CustomTooltipView(const
base::string16& tooltip, views::View* tooltip_handler)
nit: remove `views::`

https://codereview.chromium.org/2148893003/diff/1/ui/views/widget/native_widg...
ui/views/widget/native_widget_mac_unittest.mm:268: // Overridden from View:
nit: just,

// View:

https://codereview.chromium.org/2148893003/diff/1/ui/views/widget/native_widg...
ui/views/widget/native_widget_mac_unittest.mm:281: View* tooltip_handler_;  //
weak
nit: // Weak.

https://codereview.chromium.org/2148893003/diff/1/ui/views/widget/native_widg...
ui/views/widget/native_widget_mac_unittest.mm:282: };
nit: DISALLOW_COPY_AND_ASSIGN(CustomTooltipView); (with a blank line before it)

https://codereview.chromium.org/2148893003/diff/1/ui/views/widget/native_widg...
ui/views/widget/native_widget_mac_unittest.mm:833: // Tests case when mouse
events handles in one widget,
nit: handles->are handled, widget->Widget

(also this should be rewrapped at 80 chars)

https://codereview.chromium.org/2148893003/diff/1/ui/views/widget/native_widg...
ui/views/widget/native_widget_mac_unittest.mm:835: // It happens in menu
widgets, when submenu is shown above parent
nit: It happens in menus when a submenu is shown and the parent gets the
MouseExit event.

[tapted, 2016-07-15 06:24:07]

oops - bad typo - lgtm % nits :)

[kirr, 2016-07-15 07:36:09]

Thanks for review.

https://codereview.chromium.org/2148893003/diff/1/ui/views/widget/native_widg...
File ui/views/widget/native_widget_mac_unittest.mm (right):

https://codereview.chromium.org/2148893003/diff/1/ui/views/widget/native_widg...
ui/views/widget/native_widget_mac_unittest.mm:265: CustomTooltipView(const
base::string16& tooltip, views::View* tooltip_handler)
On 2016/07/15 06:23:44, tapted wrote:
> nit: remove `views::`

Done.

https://codereview.chromium.org/2148893003/diff/1/ui/views/widget/native_widg...
ui/views/widget/native_widget_mac_unittest.mm:268: // Overridden from View:
On 2016/07/15 06:23:44, tapted wrote:
> nit: just,
> 
> // View:

Done.

https://codereview.chromium.org/2148893003/diff/1/ui/views/widget/native_widg...
ui/views/widget/native_widget_mac_unittest.mm:281: View* tooltip_handler_;  //
weak
On 2016/07/15 06:23:44, tapted wrote:
> nit: // Weak.

Done.

https://codereview.chromium.org/2148893003/diff/1/ui/views/widget/native_widg...
ui/views/widget/native_widget_mac_unittest.mm:282: };
On 2016/07/15 06:23:44, tapted wrote:
> nit: DISALLOW_COPY_AND_ASSIGN(CustomTooltipView); (with a blank line before
it)

Done.

https://codereview.chromium.org/2148893003/diff/1/ui/views/widget/native_widg...
ui/views/widget/native_widget_mac_unittest.mm:833: // Tests case when mouse
events handles in one widget,
On 2016/07/15 06:23:44, tapted wrote:
> nit: handles->are handled, widget->Widget
> 
> (also this should be rewrapped at 80 chars)

Done.

https://codereview.chromium.org/2148893003/diff/1/ui/views/widget/native_widg...
ui/views/widget/native_widget_mac_unittest.mm:835: // It happens in menu
widgets, when submenu is shown above parent
On 2016/07/15 06:23:44, tapted wrote:
> nit: It happens in menus when a submenu is shown and the parent gets the
> MouseExit event.

Done.

[kirr, 2016-07-15 07:36:29]

The CQ bit was checked by kirr@yandex-team.ru

[kirr, 2016-07-15 07:36:29]

The patchset sent to the CQ was uploaded after l-g-t-m from tapted@chromium.org
Link to the patchset: https://codereview.chromium.org/2148893003/#ps20001
(title: "Nits fixed.")

[commit-bot: I haz the power, 2016-07-15 07:36:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 08:09:50]

Description was changed from

==========
MacViews: Fixed CHECK in |-updateTooltipIfRequiredAt:|.

The CHECK was occured for menu widgets in MacViews browser.
When submenu appears above parent menu, parent menu widget get MouseExit
event with location in child menu widget.
View::ConvertPointToTarget works only if two views belongs to one widget
and does not fit for this case.

BUG=569447
==========

to

==========
MacViews: Fixed CHECK in |-updateTooltipIfRequiredAt:|.

The CHECK was occured for menu widgets in MacViews browser.
When submenu appears above parent menu, parent menu widget get MouseExit
event with location in child menu widget.
View::ConvertPointToTarget works only if two views belongs to one widget
and does not fit for this case.

BUG=569447
==========

[commit-bot: I haz the power, 2016-07-15 08:09:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-15 08:09:58]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-15 08:12:58]

Description was changed from

==========
MacViews: Fixed CHECK in |-updateTooltipIfRequiredAt:|.

The CHECK was occured for menu widgets in MacViews browser.
When submenu appears above parent menu, parent menu widget get MouseExit
event with location in child menu widget.
View::ConvertPointToTarget works only if two views belongs to one widget
and does not fit for this case.

BUG=569447
==========

to

==========
MacViews: Fixed CHECK in |-updateTooltipIfRequiredAt:|.

The CHECK was occured for menu widgets in MacViews browser.
When submenu appears above parent menu, parent menu widget get MouseExit
event with location in child menu widget.
View::ConvertPointToTarget works only if two views belongs to one widget
and does not fit for this case.

BUG=569447

Committed: https://crrev.com/5a484af29ce16842a03e9a7cfcb9f273722ac5ec
Cr-Commit-Position: refs/heads/master@{#405721}
==========

[commit-bot: I haz the power, 2016-07-15 08:12:59]

Patchset 2 (id:??) landed as
https://crrev.com/5a484af29ce16842a03e9a7cfcb9f273722ac5ec
Cr-Commit-Position: refs/heads/master@{#405721}