ui/views/cocoa/bridged_content_view.mm - Issue 2148893003: MacViews: Fixed CHECK in |-updateTooltipIfRequiredAt:|.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/cocoa/bridged_content_view.mm

Issue 2148893003: MacViews: Fixed CHECK in |-updateTooltipIfRequiredAt:|. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits fixed. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/cocoa/bridged_content_view.mm

diff --git a/ui/views/cocoa/bridged_content_view.mm b/ui/views/cocoa/bridged_content_view.mm

index b6c94e328eb2216458eadaab561ea5f179033f41..625cb43c9498ed66f63e6742c7595db5f00ed6b2 100644

--- a/ui/views/cocoa/bridged_content_view.mm

+++ b/ui/views/cocoa/bridged_content_view.mm

@@ -332,7 +332,8 @@ ui::KeyEvent GetCharacterEventFromNSEvent(NSEvent* event) {

views::View* view = hostedView_->GetTooltipHandlerForPoint(locationInContent);

if (view) {

gfx::Point viewPoint = locationInContent;

- views::View::ConvertPointToTarget(hostedView_, view, &viewPoint);

+ views::View::ConvertPointToScreen(hostedView_, &viewPoint);

+ views::View::ConvertPointFromScreen(view, &viewPoint);

if (!view->GetTooltipText(viewPoint, &newTooltipText))

DCHECK(newTooltipText.empty());

}

« no previous file with comments | « no previous file | ui/views/widget/native_widget_mac_unittest.mm » ('j') | no next file with comments »