Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2148873002: [Merge M53] [Downloads] Path collision check should be case insensitive. (Closed)

Created:
4 years, 5 months ago by asanka
Modified:
4 years, 5 months ago
Reviewers:
svaldez
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

[Merge M53] [Downloads] Path collision check should be case insensitive. If there are two on-going downloads with suggested paths that only differ by case, they should be considered in conflict. Thus the download that started later should end up with a uniquified path. Otherwise the files may overwrite each other during the final rename. R=svaldez@chromium.org BUG=619516 Review-Url: https://codereview.chromium.org/2136673002 Cr-Commit-Position: refs/heads/master@{#404711} (cherry picked from commit 3f4e2aada67ac99063cc7bddf88dddf6ed93e9c0) Committed: https://chromium.googlesource.com/chromium/src/+/455b0f4daaac3f4cdeead3145446be08935dc030

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -9 lines) Patch
M chrome/browser/download/download_path_reservation_tracker.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/download/download_path_reservation_tracker_unittest.cc View 2 chunks +35 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
asanka
4 years, 5 months ago (2016-07-13 16:27:21 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
455b0f4daaac3f4cdeead3145446be08935dc030.

Powered by Google App Engine
This is Rietveld 408576698