[Downloads] Path collision check should be case insensitive.

[Downloads] Path collision check should be case insensitive.

If there are two on-going downloads with suggested paths that only
differ by case, they should be considered in conflict. Thus the download
that started later should end up with a uniquified path. Otherwise the
files may overwrite each other during the final rename.

R=svaldez@chromium.org
BUG=619516
Committed: https://crrev.com/3f4e2aada67ac99063cc7bddf88dddf6ed93e9c0
Cr-Commit-Position: refs/heads/master@{#404711}

[asanka, 2016-07-08 21:30:01]

PTAL?

[svaldez, 2016-07-11 15:40:52]

lgtm

https://codereview.chromium.org/2136673002/diff/1/chrome/browser/download/dow...
File chrome/browser/download/download_path_reservation_tracker_unittest.cc
(right):

https://codereview.chromium.org/2136673002/diff/1/chrome/browser/download/dow...
chrome/browser/download/download_path_reservation_tracker_unittest.cc:414:
EXPECT_EQ(GetPathInDownloadsDirectory(FILE_PATH_LITERAL("Foo (1).txt")),
Should the original path also be checked?

[asanka, 2016-07-11 16:27:50]

Thanks!

https://codereview.chromium.org/2136673002/diff/1/chrome/browser/download/dow...
File chrome/browser/download/download_path_reservation_tracker_unittest.cc
(right):

https://codereview.chromium.org/2136673002/diff/1/chrome/browser/download/dow...
chrome/browser/download/download_path_reservation_tracker_unittest.cc:414:
EXPECT_EQ(GetPathInDownloadsDirectory(FILE_PATH_LITERAL("Foo (1).txt")),
On 2016/07/11 at 15:40:52, svaldez wrote:
> Should the original path also be checked?

That case is covered in ConflictingReservations test above. Let me know if
that's not what you meant.

[asanka, 2016-07-11 16:27:52]

The CQ bit was checked by asanka@chromium.org

[commit-bot: I haz the power, 2016-07-11 16:28:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 17:51:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-11 17:51:32]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[asanka, 2016-07-11 18:39:18]

The CQ bit was checked by asanka@chromium.org

[commit-bot: I haz the power, 2016-07-11 18:39:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 19:54:26]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-11 19:54:38]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-11 19:56:55]

Description was changed from

==========
[Downloads] Path collision check should be case insensitive.

If there are two on-going downloads with suggested paths that only
differ by case, they should be considered in conflict. Thus the download
that started later should end up with a uniquified path. Otherwise the
files may overwrite each other during the final rename.

R=svaldez@chromium.org
BUG=619516
==========

to

==========
[Downloads] Path collision check should be case insensitive.

If there are two on-going downloads with suggested paths that only
differ by case, they should be considered in conflict. Thus the download
that started later should end up with a uniquified path. Otherwise the
files may overwrite each other during the final rename.

R=svaldez@chromium.org
BUG=619516

Committed: https://crrev.com/3f4e2aada67ac99063cc7bddf88dddf6ed93e9c0
Cr-Commit-Position: refs/heads/master@{#404711}
==========

[commit-bot: I haz the power, 2016-07-11 19:56:56]

Patchset 1 (id:??) landed as
https://crrev.com/3f4e2aada67ac99063cc7bddf88dddf6ed93e9c0
Cr-Commit-Position: refs/heads/master@{#404711}