Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Issue 2148793008: CSP: Allow ':80' to match ':443' in source expressions. (Closed)

Created:
4 years, 5 months ago by Mike West
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

CSP: Allow ':80' to match ':443' in source expressions. https://github.com/w3c/webappsec-csp/commit/22d08b990290e49f5a666fad08de16d75bb369e7#diff-117d6498d2aa8019cc0abf5eeb87a9fa updated CSP to allow insecure ports to match secure ports in source expressions. This is a refinement of the change that landed in https://codereview.chromium.org/1455973003 to address Sniffly. BUG=625945 R=jochen@chromium.org Review-Url: https://codereview.chromium.org/2125873003 Cr-Commit-Position: refs/heads/master@{#404127} (cherry picked from commit e6d181417ea462ac221d768c960a21018266a4a8) Committed: https://chromium.googlesource.com/chromium/src/+/6ebff0f8de665d2ea2a7d109ef1aeca753993396

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -2 lines) Patch
M third_party/WebKit/Source/core/frame/csp/CSPSource.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/CSPSourceTest.cpp View 3 chunks +26 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Mike West
4 years, 5 months ago (2016-07-15 18:58:55 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6ebff0f8de665d2ea2a7d109ef1aeca753993396.

Powered by Google App Engine
This is Rietveld 408576698