Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(37)

Issue 2125873003: CSP: Allow ':80' to match ':443' in source expressions. (Closed)

Created:
3 years, 5 months ago by Mike West
Modified:
3 years, 5 months ago
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CSP: Allow ':80' to match ':443' in source expressions. https://github.com/w3c/webappsec-csp/commit/22d08b990290e49f5a666fad08de16d75bb369e7#diff-117d6498d2aa8019cc0abf5eeb87a9fa updated CSP to allow insecure ports to match secure ports in source expressions. This is a refinement of the change that landed in https://codereview.chromium.org/1455973003 to address Sniffly. BUG=625945 R=jochen@chromium.org Committed: https://crrev.com/e6d181417ea462ac221d768c960a21018266a4a8 Cr-Commit-Position: refs/heads/master@{#404127}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -2 lines) Patch
M third_party/WebKit/Source/core/frame/csp/CSPSource.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/CSPSourceTest.cpp View 3 chunks +26 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
jochen (gone - plz use gerrit)
lgtm
3 years, 5 months ago (2016-07-07 08:09:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125873003/1
3 years, 5 months ago (2016-07-07 08:13:28 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/251325)
3 years, 5 months ago (2016-07-07 09:07:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125873003/1
3 years, 5 months ago (2016-07-07 10:00:32 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 5 months ago (2016-07-07 11:18:36 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
3 years, 5 months ago (2016-07-07 11:18:42 UTC) #9
commit-bot: I haz the power
3 years, 5 months ago (2016-07-07 11:20:04 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e6d181417ea462ac221d768c960a21018266a4a8
Cr-Commit-Position: refs/heads/master@{#404127}

Powered by Google App Engine
This is Rietveld 408576698