Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2148723002: Teach the preload scanner about the 'nonce' attribute. (Closed)

Created:
4 years, 5 months ago by Mike West
Modified:
4 years, 5 months ago
Reviewers:
Yoav Weiss
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Teach the preload scanner about the 'nonce' attribute. The 'nonce' attribute helps determine whether a particular script or stylesheet can be loaded in the context of a page's Content Security Policy. Currently, the preload scanner ignores this attribute, which means we might end up not preloading something we ought to preload. This patch teaches the preload scanner to store this data and pass it on with the preload request. R=yoav@yoav.ws Committed: https://crrev.com/dde5487f380cf774e4c0e96ba7f88ea68e723907 Cr-Commit-Position: refs/heads/master@{#405446}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -0 lines) Patch
M third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp View 5 chunks +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerTest.cpp View 4 chunks +50 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/PreloadRequest.h View 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/PreloadRequest.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (6 generated)
Mike West
Yoav, you know things about the preload scanner, right? Mind taking a look at this?
4 years, 5 months ago (2016-07-13 08:52:49 UTC) #1
Yoav Weiss
On 2016/07/13 08:52:49, Mike West wrote: > Yoav, you know things about the preload scanner, ...
4 years, 5 months ago (2016-07-13 12:02:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2148723002/1
4 years, 5 months ago (2016-07-14 07:34:17 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 07:38:11 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 07:38:13 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 07:39:32 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dde5487f380cf774e4c0e96ba7f88ea68e723907
Cr-Commit-Position: refs/heads/master@{#405446}

Powered by Google App Engine
This is Rietveld 408576698