Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2147853003: Teach 'LinkRequestBuilder' about the 'nonce' attribute. (Closed)

Created:
4 years, 5 months ago by Mike West
Modified:
4 years, 5 months ago
CC:
aaj, blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, gavinp+prerender_chromium.org, tfarina, Yoav Weiss
Base URL:
https://chromium.googlesource.com/chromium/src.git@preload
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Teach 'LinkRequestBuilder' about the 'nonce' attribute. Rather than special-casing stylesheet loading, this patch teaches 'LinkRequestBuilder' to grab the nonce when creating requests associated with '<link>' elements. This ensures that we deal correctly with stylesheet and HTML imports. The import tests added in 'http/tests/security/contentSecurityPolicy/nonces/' verify the expected behavior: a CSP containing "script-src 'nonce-abc'" should allow '<link rel="import" nonce="abc" href="...">'. BUG=627762 R=jochen@chromium.org Committed: https://crrev.com/dd6fbccfc7457596f386d41b822d9e93a22b4cac Cr-Commit-Position: refs/heads/master@{#405454}

Patch Set 1 #

Messages

Total messages: 10 (5 generated)
Mike West
Mind taking a look at this, Jochen? aaj@: FYI.
4 years, 5 months ago (2016-07-13 09:58:01 UTC) #1
jochen (gone - plz use gerrit)
lgtm
4 years, 5 months ago (2016-07-13 09:59:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147853003/1
4 years, 5 months ago (2016-07-14 07:48:55 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 09:20:56 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 09:22:31 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd6fbccfc7457596f386d41b822d9e93a22b4cac
Cr-Commit-Position: refs/heads/master@{#405454}

Powered by Google App Engine
This is Rietveld 408576698