Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Issue 2148683003: Fix relative file: paths in OWNERS with roots other than '/' (Closed)

Created:
4 years, 5 months ago by mbjorge
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix relative file: paths in OWNERS with roots other than '/' If an OWNERS file used the file: directive with a relative file path, but was using a root other than '/' (e.g. '/path/to/my/real/root'), then the include resolver would incorrectly leave a leading '/' on the include path. When os_path.join was then called, the leading '/' meant the path was treated as an absolute path and the join did not behave as expected. Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/f2d73522b8d989a4a325ddefdf4dc88f39eaeedb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
M owners.py View 2 chunks +2 lines, -2 lines 0 comments Download
M testing_support/filesystem_mock.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/owners_unittest.py View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
mbjorge
4 years, 5 months ago (2016-07-13 18:09:27 UTC) #2
Dirk Pranke
lgtm
4 years, 5 months ago (2016-07-14 19:16:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2148683003/1
4 years, 5 months ago (2016-07-14 20:25:25 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 20:29:02 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/f2d73522b8d989...

Powered by Google App Engine
This is Rietveld 408576698