Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Side by Side Diff: tests/owners_unittest.py

Issue 2148683003: Fix relative file: paths in OWNERS with roots other than '/' (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « testing_support/filesystem_mock.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """Unit tests for owners.py.""" 6 """Unit tests for owners.py."""
7 7
8 import os 8 import os
9 import sys 9 import sys
10 import unittest 10 import unittest
(...skipping 210 matching lines...) Expand 10 before | Expand all | Expand 10 after
221 self.assert_files_not_covered_by(['content/qux/bar.cc'], [peter], []) 221 self.assert_files_not_covered_by(['content/qux/bar.cc'], [peter], [])
222 self.assert_files_not_covered_by(['content/qux/baz.cc'], 222 self.assert_files_not_covered_by(['content/qux/baz.cc'],
223 [tom], ['content/qux/baz.cc']) 223 [tom], ['content/qux/baz.cc'])
224 224
225 def test_file_include_relative_path(self): 225 def test_file_include_relative_path(self):
226 self.assert_files_not_covered_by(['content/garply/foo.cc'], [peter], []) 226 self.assert_files_not_covered_by(['content/garply/foo.cc'], [peter], [])
227 self.assert_files_not_covered_by(['content/garply/bar.cc'], [darin], []) 227 self.assert_files_not_covered_by(['content/garply/bar.cc'], [darin], [])
228 self.assert_files_not_covered_by(['content/garply/baz.cc'], 228 self.assert_files_not_covered_by(['content/garply/baz.cc'],
229 [tom], ['content/garply/baz.cc']) 229 [tom], ['content/garply/baz.cc'])
230 230
231 def test_file_include_relative_path_non_empty_root(self):
232 old_root = self.root
233 self.root = '/content'
234 self.assert_files_not_covered_by(['garply/foo.cc'], [peter], [])
235 self.assert_files_not_covered_by(['garply/bar.cc'], [darin], [])
236 self.assert_files_not_covered_by(['garply/baz.cc'],
237 [tom], ['garply/baz.cc'])
238 self.root = old_root
239
231 def test_file_include_per_file_absolute_path(self): 240 def test_file_include_per_file_absolute_path(self):
232 self.files['/content/qux/OWNERS'] = owners_file(peter, 241 self.files['/content/qux/OWNERS'] = owners_file(peter,
233 lines=['per-file foo.*=file://content/baz/OWNERS']) 242 lines=['per-file foo.*=file://content/baz/OWNERS'])
234 243
235 self.assert_files_not_covered_by(['content/qux/foo.cc'], [brett], []) 244 self.assert_files_not_covered_by(['content/qux/foo.cc'], [brett], [])
236 self.assert_files_not_covered_by(['content/qux/baz.cc'], 245 self.assert_files_not_covered_by(['content/qux/baz.cc'],
237 [brett], ['content/qux/baz.cc']) 246 [brett], ['content/qux/baz.cc'])
238 247
239 def test_file_include_per_file_relative_path(self): 248 def test_file_include_per_file_relative_path(self):
240 self.files['/content/garply/OWNERS'] = owners_file(brett, 249 self.files['/content/garply/OWNERS'] = owners_file(brett,
(...skipping 235 matching lines...) Expand 10 before | Expand all | Expand 10 after
476 ('chrome/browser', 2)], 485 ('chrome/browser', 2)],
477 ken: [('chrome/gpu', 1)], 486 ken: [('chrome/gpu', 1)],
478 peter: [('chrome/renderer', 1)], 487 peter: [('chrome/renderer', 1)],
479 brett: [('chrome/browser', 1)]}, 488 brett: [('chrome/browser', 1)]},
480 ['chrome/gpu', 'chrome/renderer', 489 ['chrome/gpu', 'chrome/renderer',
481 'chrome/browser'], 490 'chrome/browser'],
482 ben) 491 ben)
483 492
484 if __name__ == '__main__': 493 if __name__ == '__main__':
485 unittest.main() 494 unittest.main()
OLDNEW
« no previous file with comments | « testing_support/filesystem_mock.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698