Extension API enterprise.platformKeys.

chrome/common/extensions/api/enterprise_platform_keys_internal.idl

Index: chrome/common/extensions/api/enterprise_platform_keys_internal.idl
diff --git a/chrome/common/extensions/api/enterprise_platform_keys_internal.idl b/chrome/common/extensions/api/enterprise_platform_keys_internal.idl
new file mode 100644
index 0000000000000000000000000000000000000000..41449e0950ddbd9c2b8e81ac3f62b2280c2ac4b7
--- /dev/null
+++ b/chrome/common/extensions/api/enterprise_platform_keys_internal.idl
@@ -0,0 +1,45 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Internal API for platform keys and certificate management.
+[ nodoc = true,
+  platforms = ("chromeos"),
+  implemented_in = "chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api.h" ]
+namespace enterprise.platformKeysInternal {
+  // Invoked by <code>getTokens</code>.
+  // |tokenIds| The list of IDs of the avialable Tokens.
+  callback GetTokensCallback = void(DOMString[] tokenIds);
+
+  // Invoked by <code>generateKey</code>.
+  // |publicKey| The Subject Public Key Info (see X.509) of the generated key
+  //     in DER encoding.
+  callback GenerateKeyCallback = void(ArrayBuffer publicKey);
+
+  // Invoked by <code>sign</code>.
+  // |signature| The signature, a octet string.
+  callback SignCallback = void(ArrayBuffer signature);
+
+  interface Functions {
+    // Internal version of entrprise.platformKeys.getTokens. Returns a list of
+    // token IDs instead of token objects.
+    static void getTokens(GetTokensCallback callback);
+
+    // Internal version of Token.generateKey.
+    // |tokenId| The id of a Token returned by |getTokens|.
+    // |callback| Called back with the Subject Public Key Info of the generated
+    //     key.
+    static void generateKey(DOMString tokenId, GenerateKeyCallback callback);
+
+    // Internal version of Token.sign.
+    // |tokenId| The id of a Token returned by |getTokens|.
+    // |publicKey| The Subject Public Key Info of a key previously generated by
+    //     |generateKey| in DER encoding.
+    // |data| The data to sign.
+    // |callback| Called back with the signature of |data|.
+    static void sign(DOMString tokenId,
+                     ArrayBuffer publicKey,

[pneubeck (no reviews), 2014/05/06 14:07:21]

@Benjamin,

all arguments which are currently ArrayBuffer should have type (ArrayBuffer or
ArrayBufferView).
This at first has the problem that ArrayBufferView does't have an exposed
interface object, so cannot be checked from JS.

Say, I'm using then instead (ArrayBuffer or Uint8Array).
This still has the second problem:
It's translated into
{ "name": "publicKey",
  "choices" [
  { "type": "binary",
    "isInstanceOf": "ArrayBuffer" },
  { "type": "binary",
    "isInstanceOf": "Uint8Array"}
  ]
}
(if adding support for Uint8Array).

The cc_generator.py / h_generator.py don't care about the 'isInstanceOf' and
will create a duplicate:

struct PublicKey {
 ....
 // Choices:
 scoped_ptr<std::string> as_binary;
 scoped_ptr<std::string> as_binary;
}

One way to solve this without breaking existing code is reducing redundant
Choices before passing the api schema to the h_/cc_generator.

[not at google - send to devlin, 2014/05/07 00:00:12]

Not sure what you mean by this last paragraph, but that does seem problematic.
One workaround would be to define a new dictionary type with each as a key. A
bit verbose but it's an internal API so manageable.

[pneubeck (no reviews), 2014/05/07 21:44:19]

I have to do the same for the externally visible API (see CryptoOperationData at
http://www.w3.org/TR/WebCryptoAPI/#subtlecrypto-interface), so that doesn't
help.

+                     ArrayBuffer data,
+                     SignCallback callback);
+  };
+};