Extension API enterprise.platformKeys.

chrome/browser/extensions/api/enterprise_platform_keys/token_method_nss.h

Index: chrome/browser/extensions/api/enterprise_platform_keys/token_method_nss.h
diff --git a/chrome/browser/extensions/api/enterprise_platform_keys/token_method_nss.h b/chrome/browser/extensions/api/enterprise_platform_keys/token_method_nss.h
new file mode 100644
index 0000000000000000000000000000000000000000..228b286d65acac4a8fcd4f949acc6c3f64a36663
--- /dev/null
+++ b/chrome/browser/extensions/api/enterprise_platform_keys/token_method_nss.h
@@ -0,0 +1,58 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_EXTENSIONS_API_ENTERPRISE_PLATFORM_KEYS_TOKEN_METHOD_NSS_H_
+#define CHROME_BROWSER_EXTENSIONS_API_ENTERPRISE_PLATFORM_KEYS_TOKEN_METHOD_NSS_H_
+
+#include <vector>
+
+#include "base/compiler_specific.h"
+#include "base/macros.h"
+#include "base/memory/weak_ptr.h"
+#include "chrome/common/extensions/api/enterprise_platform_keys.h"
+#include "chrome/common/extensions/api/enterprise_platform_keys_internal.h"
+#include "crypto/scoped_nss_types.h"
+
+namespace net {
+class NSSCertDatabase;
+class X509Certificate;
+typedef std::vector<scoped_refptr<X509Certificate> > CertificateList;
+}
+
+namespace extensions {
+
+namespace enterprise_platform_keys {

[not at google - send to devlin, 2014/05/05 21:09:24]

same comment re namespace, and why does this functionality (which depends on
TokenMethodExtensionFunction) in a separate file?

[pneubeck (no reviews), 2014/05/05 21:28:23]

It's the NSS specific implementation (vs. OpenSSL). As suggested by Ryan, this
shall be easily switchable.

I tried to prepare this for the second implementation in a way that depends on
as few precompiler directives as possible. The way I did it, the _nss.cc/h files
have to be conditionally compiled and the namespace alias has to be switched
from 'nss' to 'openssl'.

[not at google - send to devlin, 2014/05/07 00:00:12]

This doesn't look right, these are all effectively util functions which take
ExtensionFunctions as parameters. Just put them as member functions of the
extension functions themselves.

If you have some utility that you want to extract then sure, but not like this.

[pneubeck (no reviews), 2014/05/07 21:44:19]

The reason was that I didn't dare to do such a crazy ownership (explicitly
AddRef/Release) or passing a scoped-ptr of an object to that object.
Thus, I instead tried it with a very clear ownership and external functions (not
methods).


Anyways, changed to AddRef/Release (which I think is in principal broken, but I
will not fix that in this CL). ptal.

+
+class TokenMethodExtensionFunction;
+
+namespace nss {
+
+void Generate(
+    scoped_refptr<TokenMethodExtensionFunction> func,
+    scoped_ptr<api::enterprise_platform_keys_internal::GenerateKey::Params>
+        params);
+
+void Sign(
+    scoped_refptr<TokenMethodExtensionFunction> func,
+    scoped_ptr<api::enterprise_platform_keys_internal::Sign::Params> params);
+
+void GetCerts(
+    scoped_refptr<TokenMethodExtensionFunction> func,
+    scoped_ptr<api::enterprise_platform_keys::GetCertificates::Params> params);
+
+void Import(scoped_refptr<TokenMethodExtensionFunction> func,
+            scoped_ptr<api::enterprise_platform_keys::ImportCertificate::Params>
+                params);
+
+void Remove(scoped_refptr<TokenMethodExtensionFunction> func,
+            scoped_ptr<api::enterprise_platform_keys::RemoveCertificate::Params>
+                params);
+
+}  // namespace nss
+
+}  // namespace enterprise_platform_keys
+
+}  // namespace extensions
+
+#endif  // CHROME_BROWSER_EXTENSIONS_API_ENTERPRISE_PLATFORM_KEYS_TOKEN_METHOD_NSS_H_