mash: Move StatusTray and StatusAreaWidget to //ash/common

mash: Move StatusTray and StatusAreaWidget to //ash/common

This will make it possible to create a StatusAreaWidget under mojo::ash.

* Convert SystemTrayTest to use wm common types
* Remove unnecessary DEPS files

No functional changes.

BUG=619636
TEST=ash_unittests
TBR=stevenjb@chromium.org

Committed: https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc
Cr-Commit-Position: refs/heads/master@{#405376}

[James Cook, 2016-07-13 22:52:03]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2016-07-13 22:52:04]

msw, please take a look. Almost there!

[James Cook, 2016-07-13 22:52:11]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 22:53:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 22:57:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 22:57:53]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[msw, 2016-07-13 23:14:44]

awesome! lgtm!

https://codereview.chromium.org/2148593004/diff/20001/ash/common/system/tray/...
File ash/common/system/tray/system_tray_unittest.cc (right):

https://codereview.chromium.org/2148593004/diff/20001/ash/common/system/tray/...
ash/common/system/tray/system_tray_unittest.cc:45:
std::unique_ptr<views::Widget> CreateTestWidget(views::WidgetDelegate* delegate,
optional nit: candidate for AshTestBase? (to help convert more tests?)

[James Cook, 2016-07-13 23:42:13]

https://codereview.chromium.org/2148593004/diff/20001/ash/common/system/tray/...
File ash/common/system/tray/system_tray_unittest.cc (right):

https://codereview.chromium.org/2148593004/diff/20001/ash/common/system/tray/...
ash/common/system/tray/system_tray_unittest.cc:45:
std::unique_ptr<views::Widget> CreateTestWidget(views::WidgetDelegate* delegate,
On 2016/07/13 23:14:44, msw wrote:
> optional nit: candidate for AshTestBase? (to help convert more tests?)

Good idea. I'll do it in a separate CL because there are a couple other
CreateTestWidget() methods in other tests and I'd like to collapse them all
together.

[James Cook, 2016-07-13 23:42:38]

Description was changed from

==========
mash: Move StatusTray and StatusAreaWidget to //ash/common

This will make it possible to create a StatusAreaWidget under mojo::ash.

* Convert SystemTrayTest to use wm common types
* Remove unnecessary DEPS files

No functional changes.

BUG=619636
TEST=ash_unittests
==========

to

==========
mash: Move StatusTray and StatusAreaWidget to //ash/common

This will make it possible to create a StatusAreaWidget under mojo::ash.

* Convert SystemTrayTest to use wm common types
* Remove unnecessary DEPS files

No functional changes.

BUG=619636
TEST=ash_unittests
TBR=stevenjb@chromium.org
==========

[James Cook, 2016-07-13 23:42:38]

jamescook@chromium.org changed reviewers:
+ stevenjb@chromium.org

[James Cook, 2016-07-13 23:43:00]

TBR stevenjb for mechanical rename touching chrome/browser/chromeos

[James Cook, 2016-07-13 23:44:11]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-07-13 23:44:12]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2148593004/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-07-13 23:45:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 01:01:05]

Description was changed from

==========
mash: Move StatusTray and StatusAreaWidget to //ash/common

This will make it possible to create a StatusAreaWidget under mojo::ash.

* Convert SystemTrayTest to use wm common types
* Remove unnecessary DEPS files

No functional changes.

BUG=619636
TEST=ash_unittests
TBR=stevenjb@chromium.org
==========

to

==========
mash: Move StatusTray and StatusAreaWidget to //ash/common

This will make it possible to create a StatusAreaWidget under mojo::ash.

* Convert SystemTrayTest to use wm common types
* Remove unnecessary DEPS files

No functional changes.

BUG=619636
TEST=ash_unittests
TBR=stevenjb@chromium.org
==========

[commit-bot: I haz the power, 2016-07-14 01:01:07]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-14 01:01:14]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-14 01:04:10]

Description was changed from

==========
mash: Move StatusTray and StatusAreaWidget to //ash/common

This will make it possible to create a StatusAreaWidget under mojo::ash.

* Convert SystemTrayTest to use wm common types
* Remove unnecessary DEPS files

No functional changes.

BUG=619636
TEST=ash_unittests
TBR=stevenjb@chromium.org
==========

to

==========
mash: Move StatusTray and StatusAreaWidget to //ash/common

This will make it possible to create a StatusAreaWidget under mojo::ash.

* Convert SystemTrayTest to use wm common types
* Remove unnecessary DEPS files

No functional changes.

BUG=619636
TEST=ash_unittests
TBR=stevenjb@chromium.org

Committed: https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc
Cr-Commit-Position: refs/heads/master@{#405376}
==========

[commit-bot: I haz the power, 2016-07-14 01:04:12]

Patchset 3 (id:??) landed as
https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc
Cr-Commit-Position: refs/heads/master@{#405376}