Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2144003003: Add CreateTestWidget() to AshTestBase, collapse duplicates (Closed)

Created:
4 years, 5 months ago by James Cook
Modified:
4 years, 5 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@movetray
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add CreateTestWidget() to AshTestBase, collapse duplicates This eliminates several near-identical copies of this function. BUG=none TEST=ash_unittests Committed: https://crrev.com/e5bbe9cb96c011975841d3895c574a9815b336db Cr-Commit-Position: refs/heads/master@{#405501}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -77 lines) Patch
M ash/common/system/tray/system_tray_unittest.cc View 3 chunks +4 lines, -20 lines 0 comments Download
M ash/frame/default_header_painter_unittest.cc View 3 chunks +6 lines, -17 lines 0 comments Download
M ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc View 4 chunks +4 lines, -20 lines 0 comments Download
M ash/system/web_notification/web_notification_tray_unittest.cc View 2 chunks +3 lines, -15 lines 0 comments Download
M ash/test/ash_test_base.h View 3 chunks +17 lines, -5 lines 0 comments Download
M ash/test/ash_test_base.cc View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
James Cook
msw, please take a look.
4 years, 5 months ago (2016-07-14 00:18:33 UTC) #3
msw
lgtm
4 years, 5 months ago (2016-07-14 00:26:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2144003003/20001
4 years, 5 months ago (2016-07-14 15:41:50 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-14 16:22:15 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 16:22:27 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 16:23:22 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e5bbe9cb96c011975841d3895c574a9815b336db
Cr-Commit-Position: refs/heads/master@{#405501}

Powered by Google App Engine
This is Rietveld 408576698