[Subzero][MIPS32] Implement post lower legalizer for MIPS32

[Subzero][MIPS32] Implement post lower legalizer for MIPS32

BUG=none
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=5674c915958f2f7e3fceb08d65676a6762b68a81

[sagar.thakur, 2016-07-13 13:27:27]

sagar.thakur@imgtec.com changed reviewers:
+ eholk@chromium.org, jpp@chromium.org, kschimpf@google.com,
srdjan.obucina@imgtec.com, stichnot@chromium.org

[Jim Stichnoth, 2016-07-14 00:34:45]

https://codereview.chromium.org/2148593003/diff/1/src/IceTargetLoweringMIPS32...
File src/IceTargetLoweringMIPS32.cpp (right):

https://codereview.chromium.org/2148593003/diff/1/src/IceTargetLoweringMIPS32...
src/IceTargetLoweringMIPS32.cpp:1017: Type DestTy = Dest->getType();
const Type ...

https://codereview.chromium.org/2148593003/diff/1/src/IceTargetLoweringMIPS32...
src/IceTargetLoweringMIPS32.cpp:1018: assert(DestTy != IceType_i64);
Also add "(void)DestTy;" to avoid a compiler warning in the MINIMAL=1 build.

https://codereview.chromium.org/2148593003/diff/1/src/IceTargetLoweringMIPS32...
src/IceTargetLoweringMIPS32.cpp:1021: Type SrcTy = Src->getType();
const Type ...

https://codereview.chromium.org/2148593003/diff/1/src/IceTargetLoweringMIPS32...
src/IceTargetLoweringMIPS32.cpp:1030: UnimplementedError(getFlags());
Is this case (dest variable without a register) going to be possible in the
future?

If yes: I prefer to structure this as "if (Dest->hasReg()) A; else B;" instead
of "if (!Dest->hasReg()) B; else A;".

If no: structure as "if (!Dest->hasReg()) {A; return;} ..." instead of "if (C) {
... return;} else ..."

I hope that's clear enough...

[sagar.thakur, 2016-07-14 11:57:00]

https://codereview.chromium.org/2148593003/diff/1/src/IceTargetLoweringMIPS32...
File src/IceTargetLoweringMIPS32.cpp (right):

https://codereview.chromium.org/2148593003/diff/1/src/IceTargetLoweringMIPS32...
src/IceTargetLoweringMIPS32.cpp:1017: Type DestTy = Dest->getType();
On 2016/07/14 00:34:45, stichnot wrote:
> const Type ...

Done.

https://codereview.chromium.org/2148593003/diff/1/src/IceTargetLoweringMIPS32...
src/IceTargetLoweringMIPS32.cpp:1018: assert(DestTy != IceType_i64);
On 2016/07/14 00:34:45, stichnot wrote:
> Also add "(void)DestTy;" to avoid a compiler warning in the MINIMAL=1 build.

Done.

https://codereview.chromium.org/2148593003/diff/1/src/IceTargetLoweringMIPS32...
src/IceTargetLoweringMIPS32.cpp:1021: Type SrcTy = Src->getType();
On 2016/07/14 00:34:45, stichnot wrote:
> const Type ...

Done.

https://codereview.chromium.org/2148593003/diff/1/src/IceTargetLoweringMIPS32...
src/IceTargetLoweringMIPS32.cpp:1030: UnimplementedError(getFlags());
On 2016/07/14 00:34:45, stichnot wrote:
> Is this case (dest variable without a register) going to be possible in the
> future?
> 
> If yes: I prefer to structure this as "if (Dest->hasReg()) A; else B;" instead
> of "if (!Dest->hasReg()) B; else A;".
> 
> If no: structure as "if (!Dest->hasReg()) {A; return;} ..." instead of "if (C)
{
> ... return;} else ..."
> 
> I hope that's clear enough...

Yes, this case is possible. I have structured the if .... else as "if
(Dest->hasReg()) A; else B;"

[Jim Stichnoth, 2016-07-14 21:49:59]

lgtm

https://codereview.chromium.org/2148593003/diff/20001/src/IceTargetLoweringMI...
File src/IceTargetLoweringMIPS32.cpp (right):

https://codereview.chromium.org/2148593003/diff/20001/src/IceTargetLoweringMI...
src/IceTargetLoweringMIPS32.cpp:1017: const Type DestTy = Dest->getType();
If DestTy and SrcTy have no other uses, this would be more compact:

  assert(Dest->getType() != IceType_i64);

But that's really minor and feel free to do it as part of another CL, or ignore
it entirely. :)

[Jim Stichnoth, 2016-07-14 21:50:40]

Description was changed from

==========
[Subzero][MIPS32] Implement post lower legalizer for MIPS32

BUG=none
==========

to

==========
[Subzero][MIPS32] Implement post lower legalizer for MIPS32

BUG=none
R=stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Jim Stichnoth, 2016-07-14 21:50:41]

Committed patchset #2 (id:20001) manually as
5674c915958f2f7e3fceb08d65676a6762b68a81 (presubmit successful).