Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 2148543002: Revert "Added the framework for having canvas/recorder/picture record depth_set's." (Closed)

Created:
4 years, 5 months ago by mtklein_C
Modified:
4 years, 5 months ago
Reviewers:
msarett
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert "Added the framework for having canvas/recorder/picture record depth_set's." 1-click revert failed. This reverts commit 6d3fb898d5f73a82e36f11c712a633c3921ed518. TBR= BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2148543002 Committed: https://skia.googlesource.com/skia/+/e504dbc092ec09c056ba3aa72693962a06d3aa4c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -137 lines) Patch
M include/core/SkCanvas.h View 3 chunks +0 lines, -12 lines 0 comments Download
M include/private/SkRecords.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/core/SkCanvas.cpp View 2 chunks +1 line, -16 lines 0 comments Download
M src/core/SkPictureFlat.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkPictureRecord.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M src/core/SkRecordDraw.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M src/core/SkRecorder.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkRecorder.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M tests/CanvasTest.cpp View 2 chunks +0 lines, -26 lines 0 comments Download
M tools/debugger/SkDebugCanvas.h View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/debugger/SkDebugCanvas.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M tools/debugger/SkDrawCommand.h View 3 chunks +1 line, -15 lines 0 comments Download
M tools/debugger/SkDrawCommand.cpp View 6 chunks +0 lines, -37 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2148543002/1
4 years, 5 months ago (2016-07-12 22:22:37 UTC) #3
msarett
lgtm
4 years, 5 months ago (2016-07-12 22:25:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/e504dbc092ec09c056ba3aa72693962a06d3aa4c
4 years, 5 months ago (2016-07-12 22:41:12 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 22:41:14 UTC) #8
Message was sent while issue was closed.
CQ bit was unchecked.

Powered by Google App Engine
This is Rietveld 408576698