Chromium Code Reviews| Index: chrome/browser/ui/startup/default_browser_infobar_delegate.h |
| diff --git a/chrome/browser/ui/startup/default_browser_infobar_delegate.h b/chrome/browser/ui/startup/default_browser_infobar_delegate.h |
| index 99b7ffd64c03ea38a1110b93a81f168e00402b84..a4f449f0f27865b33146d107652a9d6c7179d1be 100644 |
| --- a/chrome/browser/ui/startup/default_browser_infobar_delegate.h |
| +++ b/chrome/browser/ui/startup/default_browser_infobar_delegate.h |
| @@ -42,8 +42,8 @@ class DefaultBrowserInfoBarDelegate : public ConfirmInfoBarDelegate { |
| enum InfoBarUserInteraction { |
| // The user clicked the "OK" (i.e., "Set as default") button. |
| ACCEPT_INFO_BAR = 0, |
| - // The user clicked the "Cancel" (i.e., "Don't ask again") button. |
| - CANCEL_INFO_BAR = 1, |
| + // The cancel button is deprecated. |
| + // CANCEL_INFO_BAR = 1, |
| // The user did not interact with the info bar. |
| IGNORE_INFO_BAR = 2, |
|
grt (UTC plus 2)
2016/07/14 06:31:16
how about distinct buckets for "didn't interact" a
Patrick Monette
2016/07/14 17:42:57
Fixed this recently
https://codereview.chromium.or
grt (UTC plus 2)
2016/07/14 18:54:15
Damn, you're good!
|
| NUM_INFO_BAR_USER_INTERACTION_TYPES |
| @@ -62,10 +62,10 @@ class DefaultBrowserInfoBarDelegate : public ConfirmInfoBarDelegate { |
| bool ShouldExpire(const NavigationDetails& details) const override; |
| void InfoBarDismissed() override; |
| base::string16 GetMessageText() const override; |
| + int GetButtons() const override; |
| base::string16 GetButtonLabel(InfoBarButton button) const override; |
| bool OKButtonTriggersUACPrompt() const override; |
| bool Accept() override; |
| - bool Cancel() override; |
| // Declared virtual so tests can override. |
| virtual scoped_refptr<shell_integration::DefaultBrowserWorker> |