Removed the "Don't ask again" button on the default browser prompt

chrome/browser/ui/startup/default_browser_infobar_delegate.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_STARTUP_DEFAULT_BROWSER_INFOBAR_DELEGATE_H_
 #define CHROME_BROWSER_UI_STARTUP_DEFAULT_BROWSER_INFOBAR_DELEGATE_H_
 
 #include "base/feature_list.h"
 #include "chrome/browser/infobars/infobar_service.h"
 #include "chrome/browser/shell_integration.h"
@@ skipping 24 matching lines @@
  protected:
   explicit DefaultBrowserInfoBarDelegate(Profile* profile);
   ~DefaultBrowserInfoBarDelegate() override;
 
  private:
   // Possible user interactions with the default browser info bar.
   // Do not modify the ordering as it is important for UMA.
   enum InfoBarUserInteraction {
     // The user clicked the "OK" (i.e., "Set as default") button.
     ACCEPT_INFO_BAR = 0,
-    // The user clicked the "Cancel" (i.e., "Don't ask again") button.
-    CANCEL_INFO_BAR = 1,
+    // The cancel button is deprecated.
+    // CANCEL_INFO_BAR = 1,
     // The user did not interact with the info bar.
     IGNORE_INFO_BAR = 2,

[grt (UTC plus 2), 2016/07/14 06:31:16]

how about distinct buckets for "didn't interact" and "clicked the 'x' to
dismiss"?

[Patrick Monette, 2016/07/14 17:42:57]

Fixed this recently
https://codereview.chromium.org/2139753002/

[grt (UTC plus 2), 2016/07/14 18:54:15]

Damn, you're good!

     NUM_INFO_BAR_USER_INTERACTION_TYPES
   };
 
   void AllowExpiry();
 
   // ConfirmInfoBarDelegate:
   Type GetInfoBarType() const override;
   infobars::InfoBarDelegate::InfoBarIdentifier GetIdentifier() const override;
   int GetIconId() const override;
   gfx::VectorIconId GetVectorIconId() const override;
 #if defined(OS_WIN)
   gfx::Image GetIcon() const override;
 #endif  // defined(OS_WIN)
   bool ShouldExpire(const NavigationDetails& details) const override;
   void InfoBarDismissed() override;
   base::string16 GetMessageText() const override;
+  int GetButtons() const override;
   base::string16 GetButtonLabel(InfoBarButton button) const override;
   bool OKButtonTriggersUACPrompt() const override;
   bool Accept() override;
-  bool Cancel() override;
 
   // Declared virtual so tests can override.
   virtual scoped_refptr<shell_integration::DefaultBrowserWorker>
   CreateDefaultBrowserWorker(
       const shell_integration::DefaultWebClientWorkerCallback& callback);
 
   // Removes the infobar when the worker is finished setting the default
   // browser. Only used if the StickyDefaultBrowserPrompt experiment is
   // enabled.
   void OnSetAsDefaultFinished(shell_integration::DefaultWebClientState state);
 
   // The WebContents's corresponding profile.
   Profile* profile_;
 
   scoped_refptr<base::SingleThreadTaskRunner> thread_task_runner_;
 
   // Whether the info bar should be dismissed on the next navigation.
   bool should_expire_;
 
   // Used to delay the expiration of the info-bar.
   base::WeakPtrFactory<DefaultBrowserInfoBarDelegate> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(DefaultBrowserInfoBarDelegate);
 };
 
 }  // namespace chrome
 
 #endif  // CHROME_BROWSER_UI_STARTUP_DEFAULT_BROWSER_INFOBAR_DELEGATE_H_