cc: Use sublayer scale from effect tree (2)

cc: Use sublayer scale from effect tree (2)

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Committed: https://crrev.com/6be761609189fbf43aedfdf463514d3291952488
Cr-Commit-Position: refs/heads/master@{#406078}

[jaydasika, 2016-07-15 17:58:24]

Description was changed from

==========
cc: Use sublayer scale from effect tree (2)

BUG=622372
==========

to

==========
cc: Use sublayer scale from effect tree (2)

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

[jaydasika, 2016-07-15 18:02:28]

The CQ bit was checked by jaydasika@chromium.org to run a CQ dry run

[jaydasika, 2016-07-15 18:03:01]

jaydasika@chromium.org changed reviewers:
+ vollick@chromium.org, weiliangc@chromium.org

[jaydasika, 2016-07-15 18:03:01]

PTAL

[commit-bot: I haz the power, 2016-07-15 18:03:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ian Vollick, 2016-07-15 19:59:07]

lgtm % weiliangc with nit.

https://codereview.chromium.org/2148383005/diff/1/cc/trees/draw_property_util...
File cc/trees/draw_property_utils.cc (right):

https://codereview.chromium.org/2148383005/diff/1/cc/trees/draw_property_util...
cc/trees/draw_property_utils.cc:523:
ConcatInverseSublayerScale(target_effect_node, &target_to_layer);
This logic (grab the effect node, do a ternary, call Concat..) seems to be
repeated in a number of places. Could it be refactored (even if it's just the
bit to get the target effect node)?

[commit-bot: I haz the power, 2016-07-15 20:15:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 20:15:48]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[jaydasika, 2016-07-15 20:28:49]

https://codereview.chromium.org/2148383005/diff/1/cc/trees/draw_property_util...
File cc/trees/draw_property_utils.cc (right):

https://codereview.chromium.org/2148383005/diff/1/cc/trees/draw_property_util...
cc/trees/draw_property_utils.cc:523:
ConcatInverseSublayerScale(target_effect_node, &target_to_layer);
On 2016/07/15 19:59:07, vollick wrote:
> This logic (grab the effect node, do a ternary, call Concat..) seems to be
> repeated in a number of places. Could it be refactored (even if it's just the
> bit to get the target effect node)?

Done.

[jaydasika, 2016-07-15 20:42:50]

s/sublayer_scale/surface_contents_scale

[jaydasika, 2016-07-15 20:43:21]

The CQ bit was checked by jaydasika@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 20:43:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 21:53:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 21:53:12]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Ian Vollick, 2016-07-16 01:07:52]

https://codereview.chromium.org/2148383005/diff/40001/cc/trees/layer_tree_imp...
File cc/trees/layer_tree_impl.cc (right):

https://codereview.chromium.org/2148383005/diff/40001/cc/trees/layer_tree_imp...
cc/trees/layer_tree_impl.cc:976:
draw_property_utils::PostConcatSublayerScale(occlusion_effect_node,
If you're going to do a rename, should probably rename all these functions, too?

[jaydasika, 2016-07-16 02:23:15]

https://codereview.chromium.org/2148383005/diff/40001/cc/trees/layer_tree_imp...
File cc/trees/layer_tree_impl.cc (right):

https://codereview.chromium.org/2148383005/diff/40001/cc/trees/layer_tree_imp...
cc/trees/layer_tree_impl.cc:976:
draw_property_utils::PostConcatSublayerScale(occlusion_effect_node,
On 2016/07/16 01:07:51, vollick wrote:
> If you're going to do a rename, should probably rename all these functions,
too?

Done.

[jaydasika, 2016-07-16 02:23:26]

The CQ bit was checked by jaydasika@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-16 02:23:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-16 04:01:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-16 04:01:32]

Dry run: This issue passed the CQ dry run.

[weiliangc, 2016-07-18 18:16:12]

The CQ bit was checked by weiliangc@chromium.org

[weiliangc, 2016-07-18 18:16:13]

lgtm

[weiliangc, 2016-07-18 18:16:13]

The patchset sent to the CQ was uploaded after l-g-t-m from vollick@chromium.org
Link to the patchset: https://codereview.chromium.org/2148383005/#ps100001
(title: "comments")

[commit-bot: I haz the power, 2016-07-18 18:17:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 20:12:06]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-07-18 20:12:32]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-18 20:15:36]

Description was changed from

==========
cc: Use sublayer scale from effect tree (2)

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

to

==========
cc: Use sublayer scale from effect tree (2)

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Committed: https://crrev.com/6be761609189fbf43aedfdf463514d3291952488
Cr-Commit-Position: refs/heads/master@{#406078}
==========

[commit-bot: I haz the power, 2016-07-18 20:15:37]

Patchset 6 (id:??) landed as
https://crrev.com/6be761609189fbf43aedfdf463514d3291952488
Cr-Commit-Position: refs/heads/master@{#406078}