cc: Use sublayer scale from effect tree (2)

cc/trees/layer_tree_impl.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/trees/layer_tree_impl.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 952 matching lines @@
         gfx::Transform draw_transform;
         if (occlusion_surface) {
           // We are calculating transform between two render surfaces. So, we
           // need to apply the sublayer scale at target and remove the sublayer
           // scale at source.
           property_trees()->transform_tree.ComputeTransform(
               it->render_surface()->TransformTreeIndex(),
               occlusion_surface->TransformTreeIndex(), &draw_transform);
           // We don't have to apply sublayer scale when target is root.
           if (occlusion_surface->TransformTreeIndex() != 0) {
-            draw_property_utils::PostConcatSublayerScale(
-                occlusion_surface->EffectTreeIndex(),
-                property_trees()->effect_tree, &draw_transform);
+            const EffectNode* occlusion_effect_node =
+                property_trees()->effect_tree.Node(
+                    occlusion_surface->EffectTreeIndex());
+            draw_property_utils::PostConcatSublayerScale(occlusion_effect_node,

[Ian Vollick, 2016/07/16 01:07:51]

If you're going to do a rename, should probably rename all these functions, too?

[jaydasika, 2016/07/16 02:23:15]

Done.

+                                                         &draw_transform);
           }
-          draw_property_utils::ConcatInverseSublayerScale(
-              it->render_surface()->EffectTreeIndex(),
-              property_trees()->effect_tree, &draw_transform);
+          const EffectNode* effect_node = property_trees()->effect_tree.Node(
+              it->render_surface()->EffectTreeIndex());
+          draw_property_utils::ConcatInverseSublayerScale(effect_node,
+                                                          &draw_transform);
         }
 
         Occlusion occlusion =
             occlusion_tracker.GetCurrentOcclusionForContributingSurface(
                 draw_transform);
         it->render_surface()->set_occlusion_in_content_space(occlusion);
         // Masks are used to draw the contributing surface, so should have
         // the same occlusion as the surface (nothing inside the surface
         // occludes them).
         if (LayerImpl* mask = it->render_surface()->MaskLayer()) {
@@ skipping 1022 matching lines @@
 
 void LayerTreeImpl::ResetAllChangeTracking() {
   layers_that_should_push_properties_.clear();
   // Iterate over all layers, including masks and replicas.
   for (auto& layer : *layers_)
     layer->ResetChangeTracking();
   property_trees_.ResetAllChangeTracking();
 }
 
 }  // namespace cc