Use std::unique_ptr<> for WebTaskRunner::clone

Use std::unique_ptr<> for WebTaskRunner::clone

Both Chromium and Blink code can use std::unique_ptr<> recently, so now
we can express the ownership passing on the type of WebTaskRunner::clone.
This CL replaces the return type of WebTaskRunner::clone from a raw pointer
to a std::unique_ptr<>, removes adoptClone, and updates the call-sites.

Committed: https://crrev.com/d2a8f72eb23fd377b0713e2061958c6b7ecae38e
Cr-Commit-Position: refs/heads/master@{#407178}

[tzik, 2016-07-15 07:57:01]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 07:57:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2016-07-15 07:58:12]

Description was changed from

==========
Use std::unique_ptr<> for WebTaskRunner::clone

Both Chromium and Blink code can use std::unique_ptr<> recently, so now
we can express the ownership passing on the type of WebTaskRunner::clone.
==========

to

==========
Use std::unique_ptr<> for WebTaskRunner::clone

Both Chromium and Blink code can use std::unique_ptr<> recently, so now
we can express the ownership passing on the type of WebTaskRunner::clone.
This CL replaces the return type of WebTaskRunner::clone from a raw pointer
to a std::unique_ptr<>, removes adoptClone, and updates the call-sites.
==========

[tzik, 2016-07-15 08:04:29]

tzik@chromium.org changed reviewers:
+ alexclarke@chromium.org, kinuko@chromium.org, yukishiino@chromium.org

[tzik, 2016-07-15 08:04:30]

PTAL to:
yukishiino: binding/core/v8/ScriptStreamer.cpp
alexclarke: //component/scheduler/child
kinuko: //content and core and platform

[haraken, 2016-07-15 08:07:09]

WebKit LGTM

[commit-bot: I haz the power, 2016-07-15 08:33:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 08:33:59]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[kinuko, 2016-07-15 08:35:02]

lgtm

[Yuki, 2016-07-15 09:03:51]

LGTM.

[alex clarke (OOO till 29th), 2016-07-15 09:32:56]

alexclarke@chromium.org changed reviewers:
+ esprehn@chromium.org

[alex clarke (OOO till 29th), 2016-07-15 09:32:57]

+esprehn

Elliot can we somehow bridge chromium and blink reference counting? Ideally I'd
like the clone method to go away.  If we can't then this patch seems fine.

[tzik, 2016-07-15 09:44:58]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 09:45:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 10:42:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 10:43:00]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[tzik, 2016-07-19 12:56:28]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 12:56:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2016-07-19 12:58:36]

On 2016/07/15 09:32:57, alex clarke wrote:
> +esprehn
> 
> Elliot can we somehow bridge chromium and blink reference counting? Ideally
I'd
> like the clone method to go away.  If we can't then this patch seems fine.

Elliot, do you have any opinion on this?

[dcheng, 2016-07-19 13:02:36]

On 2016/07/19 12:58:36, tzik wrote:
> On 2016/07/15 09:32:57, alex clarke wrote:
> > +esprehn
> > 
> > Elliot can we somehow bridge chromium and blink reference counting? Ideally
> I'd
> > like the clone method to go away.  If we can't then this patch seems fine.
> 
> Elliot, do you have any opinion on this?

For historical context, we've traditionally tried to avoid exposing the
refcounted nature of Blink objects in the public API layer. That's why we have
things like WebFrame::close() and WebView::close(), which hide the nature of the
refcounting. Is having clone() here problematic?

[alex clarke (OOO till 29th), 2016-07-19 14:10:46]

On 2016/07/19 13:02:36, dcheng wrote:
> On 2016/07/19 12:58:36, tzik wrote:
> > On 2016/07/15 09:32:57, alex clarke wrote:
> > > +esprehn
> > > 
> > > Elliot can we somehow bridge chromium and blink reference counting?
Ideally
> > I'd
> > > like the clone method to go away.  If we can't then this patch seems fine.
> > 
> > Elliot, do you have any opinion on this?
> 
> For historical context, we've traditionally tried to avoid exposing the
> refcounted nature of Blink objects in the public API layer. That's why we have
> things like WebFrame::close() and WebView::close(), which hide the nature of
the
> refcounting. Is having clone() here problematic?

In chrome code you can just pass TaskQueue's around, in blink you need to
remember to clone them.  It's not a big problem.  If fixing that isn't feasible
then I'm fine with this patch.

[commit-bot: I haz the power, 2016-07-19 14:37:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 14:37:53]

Dry run: This issue passed the CQ dry run.

[esprehn, 2016-07-22 05:54:26]

esprehn@chromium.org changed reviewers:
+ haraken@chromium.org

[esprehn, 2016-07-22 05:54:28]

lgtm, much better than bare ptrs. Yeah we need to deal with the RefCounted
stuff, but lets do that later.

[alex clarke (OOO till 29th), 2016-07-22 09:35:38]

On 2016/07/22 05:54:28, esprehn wrote:
> lgtm, much better than bare ptrs. Yeah we need to deal with the RefCounted
> stuff, but lets do that later.

Ok then lets go with this.

LGTM

[tzik, 2016-07-22 15:31:35]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 15:31:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2016-07-22 16:01:32]

The CQ bit was unchecked by tzik@chromium.org

[tzik, 2016-07-22 16:01:42]

The CQ bit was checked by tzik@chromium.org

[tzik, 2016-07-22 16:01:42]

The patchset sent to the CQ was uploaded after l-g-t-m from kinuko@chromium.org,
haraken@chromium.org, yukishiino@chromium.org, esprehn@chromium.org,
alexclarke@chromium.org
Link to the patchset: https://codereview.chromium.org/2148363004/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-07-22 16:02:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 17:03:54]

Description was changed from

==========
Use std::unique_ptr<> for WebTaskRunner::clone

Both Chromium and Blink code can use std::unique_ptr<> recently, so now
we can express the ownership passing on the type of WebTaskRunner::clone.
This CL replaces the return type of WebTaskRunner::clone from a raw pointer
to a std::unique_ptr<>, removes adoptClone, and updates the call-sites.
==========

to

==========
Use std::unique_ptr<> for WebTaskRunner::clone

Both Chromium and Blink code can use std::unique_ptr<> recently, so now
we can express the ownership passing on the type of WebTaskRunner::clone.
This CL replaces the return type of WebTaskRunner::clone from a raw pointer
to a std::unique_ptr<>, removes adoptClone, and updates the call-sites.
==========

[commit-bot: I haz the power, 2016-07-22 17:03:57]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-22 17:06:04]

Description was changed from

==========
Use std::unique_ptr<> for WebTaskRunner::clone

Both Chromium and Blink code can use std::unique_ptr<> recently, so now
we can express the ownership passing on the type of WebTaskRunner::clone.
This CL replaces the return type of WebTaskRunner::clone from a raw pointer
to a std::unique_ptr<>, removes adoptClone, and updates the call-sites.
==========

to

==========
Use std::unique_ptr<> for WebTaskRunner::clone

Both Chromium and Blink code can use std::unique_ptr<> recently, so now
we can express the ownership passing on the type of WebTaskRunner::clone.
This CL replaces the return type of WebTaskRunner::clone from a raw pointer
to a std::unique_ptr<>, removes adoptClone, and updates the call-sites.

Committed: https://crrev.com/d2a8f72eb23fd377b0713e2061958c6b7ecae38e
Cr-Commit-Position: refs/heads/master@{#407178}
==========

[commit-bot: I haz the power, 2016-07-22 17:06:06]

Patchset 4 (id:??) landed as
https://crrev.com/d2a8f72eb23fd377b0713e2061958c6b7ecae38e
Cr-Commit-Position: refs/heads/master@{#407178}