third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp - Issue 2148363004: Use std::unique_ptr<> for WebTaskRunner::clone

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp

Issue 2148363004: Use std::unique_ptr<> for WebTaskRunner::clone (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp

diff --git a/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp b/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp

index 7f531985ea47aeb3f0feaea7e0e54fb9f10eb47f..09937a62189e22198624953086078889bb59b310 100644

--- a/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp

+++ b/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp

@@ -156,7 +156,7 @@ class MockTaskRunner : public blink::WebTaskRunner {

void postTask(const WebTraceLocation&, Task*) override { }

void postDelayedTask(const WebTraceLocation&, Task*, double) override { }

bool runsTasksOnCurrentThread() override { return true; }

- WebTaskRunner* clone() override { return nullptr; }

+ std::unique_ptr<WebTaskRunner> clone() override { return nullptr; }

double virtualTimeSeconds() const override { return 0.0; }

double monotonicallyIncreasingVirtualTimeSeconds() const override { return 0.0; }

};