Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2148363002: Move document.write evaluation after standard preloads (Closed)

Created:
4 years, 5 months ago by Charlie Harrison
Modified:
4 years, 5 months ago
Reviewers:
kouhei (in TOK)
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Move document.write evaluation after standard preloads This patch moves document.write evaluation to take place after all the preloads the HTMLDocumentParser knows about are fetched. This shaves off preload delay when the evaluator is busy evaluating or initializing the context. BUG=627575 Review-Url: https://codereview.chromium.org/2146673002 Cr-Commit-Position: refs/heads/master@{#405026} (cherry picked from commit 9cb7a71a7369a77b2d0c400b2a7e436f489bc2c0) TBR=kouhei@chromium.org NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp View 2 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2148363002/1
4 years, 5 months ago (2016-07-14 17:59:50 UTC) #2
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 5 months ago (2016-07-14 17:59:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2148363002/1
4 years, 5 months ago (2016-07-14 18:15:16 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 18:20:49 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 18:21:04 UTC) #10
Message was sent while issue was closed.
CQ bit was unchecked.

Powered by Google App Engine
This is Rietveld 408576698