Move document.write evaluation after standard preloads

Move document.write evaluation after standard preloads

This patch moves document.write evaluation to take place after all the
preloads the HTMLDocumentParser knows about are fetched.

This shaves off preload delay when the evaluator is busy evaluating or
initializing the context.

BUG=627575
Committed: https://crrev.com/9cb7a71a7369a77b2d0c400b2a7e436f489bc2c0
Cr-Commit-Position: refs/heads/master@{#405026}

[Charlie Harrison, 2016-07-12 19:51:19]

csharrison@chromium.org changed reviewers:
+ kouhei@chromium.org

[Charlie Harrison, 2016-07-12 19:51:20]

ptal at this one. This is a minor perf improvement on the experiment.

[kouhei (in TOK), 2016-07-13 01:01:29]

lgtm % bug# (you can merge this to the doc.write umbrella bug)

https://codereview.chromium.org/2146673002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp (right):

https://codereview.chromium.org/2146673002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp:318:
m_preloader->takeAndPreload(chunk->preloads);
Makes sense. Can we have a comment re: why we need two separate loops and
process preloads earlier?

[Charlie Harrison, 2016-07-13 03:12:20]

Description was changed from

==========
Move document.write evaluation after standard preloads

This patch moves document.write evaluation to take place after all the
preloads the HTMLDocumentParser knows about are fetched.

This shaves off preload delay when the evaluator is busy evaluating or
initializing the context.

BUG=
==========

to

==========
Move document.write evaluation after standard preloads

This patch moves document.write evaluation to take place after all the
preloads the HTMLDocumentParser knows about are fetched.

This shaves off preload delay when the evaluator is busy evaluating or
initializing the context.

BUG=627575
==========

[Charlie Harrison, 2016-07-13 03:13:45]

I actually had a bug for this but forgot to set the BUG=, thanks for the review!

https://codereview.chromium.org/2146673002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp (right):

https://codereview.chromium.org/2146673002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp:318:
m_preloader->takeAndPreload(chunk->preloads);
On 2016/07/13 01:01:28, kouhei wrote:
> Makes sense. Can we have a comment re: why we need two separate loops and
> process preloads earlier?

Done.

[Charlie Harrison, 2016-07-13 03:15:22]

The CQ bit was checked by csharrison@chromium.org

[Charlie Harrison, 2016-07-13 03:15:22]

The patchset sent to the CQ was uploaded after l-g-t-m from kouhei@chromium.org
Link to the patchset: https://codereview.chromium.org/2146673002/#ps20001
(title: "Add comment explaining double for loop")

[commit-bot: I haz the power, 2016-07-13 03:17:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 04:45:31]

Description was changed from

==========
Move document.write evaluation after standard preloads

This patch moves document.write evaluation to take place after all the
preloads the HTMLDocumentParser knows about are fetched.

This shaves off preload delay when the evaluator is busy evaluating or
initializing the context.

BUG=627575
==========

to

==========
Move document.write evaluation after standard preloads

This patch moves document.write evaluation to take place after all the
preloads the HTMLDocumentParser knows about are fetched.

This shaves off preload delay when the evaluator is busy evaluating or
initializing the context.

BUG=627575
==========

[commit-bot: I haz the power, 2016-07-13 04:45:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-13 04:48:08]

Description was changed from

==========
Move document.write evaluation after standard preloads

This patch moves document.write evaluation to take place after all the
preloads the HTMLDocumentParser knows about are fetched.

This shaves off preload delay when the evaluator is busy evaluating or
initializing the context.

BUG=627575
==========

to

==========
Move document.write evaluation after standard preloads

This patch moves document.write evaluation to take place after all the
preloads the HTMLDocumentParser knows about are fetched.

This shaves off preload delay when the evaluator is busy evaluating or
initializing the context.

BUG=627575

Committed: https://crrev.com/9cb7a71a7369a77b2d0c400b2a7e436f489bc2c0
Cr-Commit-Position: refs/heads/master@{#405026}
==========

[commit-bot: I haz the power, 2016-07-13 04:48:12]

Patchset 2 (id:??) landed as
https://crrev.com/9cb7a71a7369a77b2d0c400b2a7e436f489bc2c0
Cr-Commit-Position: refs/heads/master@{#405026}