Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 2148333002: [Mac/GN] If !debug_devtools, define a dummy target for //chrome:devtools_debug_resources. (Closed)

Created:
4 years, 5 months ago by Robert Sesek
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac/GN] If !debug_devtools, define a dummy target for //chrome:devtools_debug_resources. Because devtools_debug_resources is an action, it runs if building all, regardless of whether //chrome depends on it. BUG=628167 R=dpranke@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/4df9b9bce20df17d9afeeb752bff756d46f5d645

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -22 lines) Patch
M chrome/BUILD.gn View 1 chunk +27 lines, -22 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Robert Sesek
4 years, 5 months ago (2016-07-14 17:54:25 UTC) #3
Dirk Pranke
lgtm
4 years, 5 months ago (2016-07-14 18:17:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2148333002/1
4 years, 5 months ago (2016-07-14 18:42:20 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4df9b9bce20df17d9afeeb752bff756d46f5d645 Cr-Commit-Position: refs/heads/master@{#405528}
4 years, 5 months ago (2016-07-14 19:08:29 UTC) #10
Robert Sesek
4 years, 5 months ago (2016-07-14 19:09:28 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4df9b9bce20df17d9afeeb752bff756d46f5d645 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698