Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: chrome/BUILD.gn

Issue 2148333002: [Mac/GN] If !debug_devtools, define a dummy target for //chrome:devtools_debug_resources. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index cc77145eed39f0ce4cdd833724bcb8a731a30ef3..b2d01f34dc370be2638fee9ea3f06599e0b8276b 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -762,32 +762,37 @@ if (is_win) {
# framework in the app bundle, rather than the framework bundle in
# root_out_dir, since copy_bundle_data copies the contents of the link
# rather than the link itself.
- action("devtools_debug_resources") {
- _stamp = "$target_out_dir/run_${target_name}.stamp"
+ if (debug_devtools) {
+ action("devtools_debug_resources") {
+ _stamp = "$target_out_dir/run_${target_name}.stamp"
- outputs = [
- _stamp,
- ]
+ outputs = [
+ _stamp,
+ ]
- script = "//build/symlink.py"
- args = [
- "-f",
- "--touch",
- rebase_path(_stamp, root_out_dir),
+ script = "//build/symlink.py"
+ args = [
+ "-f",
+ "--touch",
+ rebase_path(_stamp, root_out_dir),
- # Convert the symlink source and destination to an absolute paths, which
- # makes symlinking easier (now pwd manipulation).
- rebase_path("$root_out_dir/resources/inspector"),
- rebase_path(
- "$root_out_dir/$chrome_product_full_name.app/Contents/Versions/$chrome_version_full/$chrome_framework_name.framework/Resources/inspector"),
- ]
+ # Convert the symlink source and destination to an absolute paths, which
+ # makes symlinking easier (now pwd manipulation).
+ rebase_path("$root_out_dir/resources/inspector"),
+ rebase_path(
+ "$root_out_dir/$chrome_product_full_name.app/Contents/Versions/$chrome_version_full/$chrome_framework_name.framework/Resources/inspector"),
+ ]
- deps = [
- # Depend on :chrome_app to ensure that the bundle is produced before
- # creating or destroying the symlink.
- ":chrome_app",
- "//third_party/WebKit/public:blink_devtools_frontend_resources",
- ]
+ deps = [
+ # Depend on :chrome_app to ensure that the bundle is produced before
+ # creating or destroying the symlink.
+ ":chrome_app",
+ "//third_party/WebKit/public:blink_devtools_frontend_resources",
+ ]
+ }
+ } else {
+ group("devtools_debug_resources") {
+ }
}
if (enable_nacl) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698