Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 214833004: Revert 259788 "Fixup mojo dylibs" (Closed)

Created:
6 years, 9 months ago by bajones
Modified:
6 years, 9 months ago
Reviewers:
DaveMoore
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 259788 "Fixup mojo dylibs" Broke Mac GPU bots. content_gl_tests began failing with: dyld: Library not loaded: @loader_path/libmojo_system.dylib Referenced from: /tmp/run_tha_testiM3m5a/out/Release/content_gl_tests Reason: image not found > Fixup mojo dylibs > > BUG= > R=mark@chromium.org > > Review URL: https://codereview.chromium.org/211503005 TBR=davemoore@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259908

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -76 lines) Patch
M trunk/src/build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/chrome_dll_bundle.gypi View 2 chunks +1 line, -30 lines 0 comments Download
M trunk/src/chrome/tools/build/mac/dump_product_syms View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/content/content_shell.gypi View 1 chunk +1 line, -30 lines 0 comments Download
M trunk/src/mojo/mojo_public.gypi View 3 chunks +24 lines, -14 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
bajones
6 years, 9 months ago (2014-03-27 16:32:28 UTC) #1
bajones
6 years, 9 months ago (2014-03-27 16:32:36 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r259908.

Powered by Google App Engine
This is Rietveld 408576698