Fixup mojo dylibs to support mojo in content

Fixup mojo dylibs

BUG=
R=mark@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259788

[DaveMoore, 2014-03-25 20:33:46]

Turn on only for mac

[DaveMoore, 2014-03-25 20:39:27]

Only add mac to supported mojo platforms

[Mark Mentovai, 2014-03-25 21:03:10]

What’s the policy for what other parts of Chrome mojo is allowed to depend on?

https://codereview.chromium.org/211503005/diff/70001/mojo/mojo_public.gypi
File mojo/mojo_public.gypi (right):

https://codereview.chromium.org/211503005/diff/70001/mojo/mojo_public.gypi#ne...
mojo/mojo_public.gypi:31: },
We need to arrange for libmojo_system’s symbols to be dumped properly for
Breakpad too. Within this, do

          'conditions': [
            ['mac_breakpad==1', {
              'variables': {
                # A real .dSYM is needed for dump_syms to operate on.
                'mac_real_dsym': 1,
              },
            ],

You also need to add libmojo_system.dylib to the list of things whose symbols
should be dumped by Breakpad in chrome/tools/build/mac/dump_product_syms.

[DaveMoore, 2014-03-25 21:44:55]

Add breakpad support

[DaveMoore, 2014-03-25 21:46:29]

mojo_system isn't allowed to be dependent on any other parts of chromium.

https://codereview.chromium.org/211503005/diff/70001/mojo/mojo_public.gypi
File mojo/mojo_public.gypi (right):

https://codereview.chromium.org/211503005/diff/70001/mojo/mojo_public.gypi#ne...
mojo/mojo_public.gypi:31: },
On 2014/03/25 21:03:10, Mark Mentovai wrote:
> We need to arrange for libmojo_system’s symbols to be dumped properly for
> Breakpad too. Within this, do
> 
>           'conditions': [
>             ['mac_breakpad==1', {
>               'variables': {
>                 # A real .dSYM is needed for dump_syms to operate on.
>                 'mac_real_dsym': 1,
>               },
>             ],
> 
> You also need to add libmojo_system.dylib to the list of things whose symbols
> should be dumped by Breakpad in chrome/tools/build/mac/dump_product_syms.

Done.

[Mark Mentovai, 2014-03-25 21:50:04]

LGTM.

That’s the right answer—not allowed to depend on other parts of Chromium. The
DEPS file is scary, though, because it says base is OK. I assume that’s for
testing or other non-lmojo_system uses. You may want to reorganize the files so
that the mojo_system ones can have a DEPS file that declares that base isn’t
allowed. It could be pretty bad for a shared library that Chrome loads to have
its own copy of base or another part of Chrome, in addition to the copy that
Chrome has.

[DaveMoore, 2014-03-25 22:13:33]

The CQ bit was checked by davemoore@chromium.org

[commit-bot: I haz the power, 2014-03-25 22:16:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/davemoore@chromium.org/211503005/160001

[commit-bot: I haz the power, 2014-03-25 22:50:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-25 22:50:12]

Try jobs failed on following builders:
  tryserver.chromium on mac_chromium_rel

[DaveMoore, 2014-03-26 16:39:45]

Copy explicitly instead of copies command

[DaveMoore, 2014-03-26 16:40:52]

PTAL

The previous version failed on bots with static_library builds.

[DaveMoore, 2014-03-26 16:44:32]

Copy explicitly instead of copies command

[Mark Mentovai, 2014-03-26 16:56:54]

LGTM

https://codereview.chromium.org/211503005/diff/340001/chrome/chrome_dll_bundl...
File chrome/chrome_dll_bundle.gypi (right):

https://codereview.chromium.org/211503005/diff/340001/chrome/chrome_dll_bundl...
chrome/chrome_dll_bundle.gypi:131: # Copy libmojo_system.dylib explicitly. The
copies command hard
Missing a word (“creates?”)

Can you move this postbuild block to be right before the one that runs
install_name_tool on it? Proximity is helpful.

https://codereview.chromium.org/211503005/diff/340001/content/content_shell.gypi
File content/content_shell.gypi (right):

https://codereview.chromium.org/211503005/diff/340001/content/content_shell.g...
content/content_shell.gypi:857: # Copy libmojo_system.dylib explicitly. The
copies command hard
Same comments apply here.

[DaveMoore, 2014-03-26 17:30:27]

Update some comments for clarity

[DaveMoore, 2014-03-26 22:03:51]

Change other mojo dylibs to loader_path from rpath as well

[DaveMoore, 2014-03-27 00:58:03]

The CQ bit was checked by davemoore@chromium.org

[commit-bot: I haz the power, 2014-03-27 00:59:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/davemoore@chromium.org/211503005/370001

[DaveMoore, 2014-03-27 05:24:28]

Committed patchset #8 manually as r259788 (presubmit successful).

[DaveMoore, 2014-03-28 02:47:58]

Add isolate support