components/autofill/content/renderer/form_cache.cc - Issue 2148303005: [Password Generation] Sends the flag whether a field has nonempty user input

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/form_cache.cc

Issue 2148303005: [Password Generation] Sends the flag whether a field has nonempty user input (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes addressed to reviewer comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/content/renderer/form_autofill_util.h ('K') | « components/autofill/content/renderer/form_autofill_util.cc ('k') | components/autofill/content/renderer/password_autofill_agent.h » ('j') | components/autofill/content/renderer/password_autofill_agent.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/form_cache.cc

diff --git a/components/autofill/content/renderer/form_cache.cc b/components/autofill/content/renderer/form_cache.cc

index 2d69822a5b0b183ca2be967a696d962a6b9061fe..28779993d3d2326cc2730384b10daf16c6c08ead 100644

--- a/components/autofill/content/renderer/form_cache.cc

+++ b/components/autofill/content/renderer/form_cache.cc

@@ -123,7 +123,7 @@ std::vector<FormData> FormCache::ExtractNewForms() {

FormData form;

if (!WebFormElementToFormData(form_element, WebFormControlElement(),

- extract_mask, &form, nullptr)) {

+ nullptr, extract_mask, &form, nullptr)) {

continue;

}