Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: components/autofill/content/renderer/form_autofill_util.h

Issue 2148303005: [Password Generation] Sends the flag whether a field has nonempty user input (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes addressed to reviewer comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/form_autofill_util.h
diff --git a/components/autofill/content/renderer/form_autofill_util.h b/components/autofill/content/renderer/form_autofill_util.h
index 7f2391dcbf731582d143896e87c92f456e35e664..4d22327af907ed991d09e29f09251c9652210e5d 100644
--- a/components/autofill/content/renderer/form_autofill_util.h
+++ b/components/autofill/content/renderer/form_autofill_util.h
@@ -11,6 +11,7 @@
#include "base/macros.h"
#include "base/strings/string16.h"
+#include <components/autofill/content/renderer/password_form_conversion_utils.h>
#include "components/autofill/core/common/autofill_constants.h"
#include "components/autofill/core/common/password_form_field_prediction_map.h"
#include "third_party/WebKit/public/platform/WebVector.h"
@@ -146,6 +147,7 @@ std::vector<blink::WebFormControlElement> ExtractAutofillableElementsInForm(
// |extract_mask|: See the enum ExtractMask above for details.
void WebFormControlElementToFormField(
const blink::WebFormControlElement& element,
+ const FieldValueAndPropertiesMaskMap* field_value_and_properties_map,
vabr (Chromium) 2016/07/28 11:33:53 nit: Please describe the added argument in the met
kolos1 2016/07/28 13:44:03 Done.
ExtractMask extract_mask,
FormFieldData* field);
@@ -157,6 +159,7 @@ void WebFormControlElementToFormField(
bool WebFormElementToFormData(
const blink::WebFormElement& form_element,
const blink::WebFormControlElement& form_control_element,
+ const FieldValueAndPropertiesMaskMap* field_value_and_properties_map,
ExtractMask extract_mask,
FormData* form,
FormFieldData* field);
@@ -198,6 +201,7 @@ bool UnownedPasswordFormElementsAndFieldSetsToFormData(
const std::vector<blink::WebFormControlElement>& control_elements,
const blink::WebFormControlElement* element,
const blink::WebDocument& document,
+ const FieldValueAndPropertiesMaskMap* field_value_and_properties_map,
ExtractMask extract_mask,
FormData* form,
FormFieldData* field);

Powered by Google App Engine
This is Rietveld 408576698