chrome/renderer/autofill/password_generation_test_utils.cc - Issue 2148303005: [Password Generation] Sends the flag whether a field has nonempty user input

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/autofill/password_generation_test_utils.cc

Issue 2148303005: [Password Generation] Sends the flag whether a field has nonempty user input (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes addressed to reviewer comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/autofill/password_autofill_agent_browsertest.cc ('K') | « chrome/renderer/autofill/password_autofill_agent_browsertest.cc ('k') | components/autofill/content/common/autofill_messages.h » ('j') | components/autofill/content/renderer/form_autofill_util.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/autofill/password_generation_test_utils.cc

diff --git a/chrome/renderer/autofill/password_generation_test_utils.cc b/chrome/renderer/autofill/password_generation_test_utils.cc

index 4863b90b36a4a80648d29c1ddb69c7a66d044dad..3b1c819bdb82f34f9c560a857be696c60248907b 100644

--- a/chrome/renderer/autofill/password_generation_test_utils.cc

+++ b/chrome/renderer/autofill/password_generation_test_utils.cc

@@ -37,7 +37,7 @@ void SetAccountCreationFormsDetectedMessage(

autofill::FormData form_data;

WebFormElementToFormData(

- web_forms[form_index], blink::WebFormControlElement(),

+ web_forms[form_index], blink::WebFormControlElement(), nullptr,

form_util::EXTRACT_NONE, &form_data, nullptr /* FormFieldData */);

std::vector<autofill::PasswordFormGenerationData> forms;