Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(880)

Issue 214823003: Please Valgrind by calling preConcat. (Closed)

Created:
6 years, 9 months ago by mtklein_C
Modified:
6 years, 8 months ago
Reviewers:
bsalomon, mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Please Valgrind by calling preConcat. Valgrind's whining about m.setConcat(m, I). That special cases into m = m, which compiles into memcpy(&m, &m, sizeof(m)), and then Valgrind decides that's not kosher because &m and &m overlap. (memmove would have been fine, but this is compiler generated code; not much we can do.) preConcat gets us the same thing with an early can-we-noop check for I, sidestepping the whole problem. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13972

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/gpu/gl/GrGLProgram.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
mtklein
6 years, 9 months ago (2014-03-27 17:07:09 UTC) #1
bsalomon
lgtm
6 years, 9 months ago (2014-03-27 17:11:34 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 9 months ago (2014-03-27 17:12:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/214823003/1
6 years, 9 months ago (2014-03-27 17:12:53 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-28 14:19:17 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-03-28 14:19:17 UTC) #6
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 8 months ago (2014-03-28 14:29:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/214823003/1
6 years, 8 months ago (2014-03-28 14:29:10 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-03-28 14:29:25 UTC) #9
Message was sent while issue was closed.
Change committed as 13972

Powered by Google App Engine
This is Rietveld 408576698