src/gpu/gl/GrGLProgram.h - Issue 214823003: Please Valgrind by calling preConcat.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/gl/GrGLProgram.h

Issue 214823003: Please Valgrind by calling preConcat. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/gl/GrGLProgram.h

diff --git a/src/gpu/gl/GrGLProgram.h b/src/gpu/gl/GrGLProgram.h

index 8e2ae74aab991696ebc56ca34d00bd0cc97fc4b5..0a2a242fca3a88cf64572a96a8f42773a5f102e8 100644

--- a/src/gpu/gl/GrGLProgram.h

+++ b/src/gpu/gl/GrGLProgram.h

@@ -114,7 +114,7 @@ public:

0, SkIntToScalar(2) / fRenderTargetSize.fHeight, -SK_Scalar1,

0, 0, SkMatrix::I()[8]);

}

- combined.setConcat(combined, fViewMatrix);

+ combined.preConcat(fViewMatrix);

GrGLGetMatrix<Size>(destMatrix, combined);

}

};

« no previous file with comments | « no previous file | no next file » | no next file with comments »