Issue 2148173002: Fix layout object lifecycle in HTMLElement.offset*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2148173002: Fix layout object lifecycle in HTMLElement.offset* (Closed)

Created:
4 years, 5 months ago by kochi

Modified:
4 years, 5 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2785

Target Ref:
refs/pending/branch-heads/2785

Project:
chromium

Visibility:
Public.

Fix layout object lifecycle in HTMLElement.offset* In HTMLElement.offset{Left,Top,Width,Height}, it calls offsetParent, which may cause style recalculation and layout object will be recreated. BUG=625903 Review-Url: https://codereview.chromium.org/2126713003 Cr-Commit-Position: refs/heads/master@{#404081} (cherry picked from commit 5c480f3117fe314b8cace4f33b84020e9e3424e2) Committed: https://chromium.googlesource.com/chromium/src/+/981c561ca2d2f805cbfe7c16b6369edbf6219846

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -8 lines)			Patch
	A	third_party/WebKit/LayoutTests/shadow-dom/crashes/offsetParent-layoutObject-lifecycle.html	View		1 chunk	+25 lines, -0 lines	0 comments	Download
	M	third_party/WebKit/Source/core/html/HTMLElement.cpp	View		1 chunk	+8 lines, -8 lines	0 comments	Download

Total messages: 2 (1 generated)

kochi

4 years, 5 months ago (2016-07-14 06:53:20 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
981c561ca2d2f805cbfe7c16b6369edbf6219846.