Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2126713003: Fix layout object lifecycle in HTMLElement.offset* (Closed)

Created:
4 years, 5 months ago by kochi
Modified:
4 years, 5 months ago
Reviewers:
hayato
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix layout object lifecycle in HTMLElement.offset* In HTMLElement.offset{Left,Top,Width,Height}, it calls offsetParent, which may cause style recalculation and layout object will be recreated. BUG=625903 Committed: https://crrev.com/5c480f3117fe314b8cace4f33b84020e9e3424e2 Cr-Commit-Position: refs/heads/master@{#404081}

Patch Set 1 #

Patch Set 2 : layout test only #

Patch Set 3 : fix again #

Total comments: 4

Patch Set 4 : Update layout test for comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -8 lines) Patch
A third_party/WebKit/LayoutTests/shadow-dom/crashes/offsetParent-layoutObject-lifecycle.html View 1 2 3 1 chunk +25 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLElement.cpp View 2 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126713003/1
4 years, 5 months ago (2016-07-06 09:57:54 UTC) #2
kochi
PTAL See also https://bugs.chromium.org/p/chromium/issues/detail?id=625903#c5 for the problem details.
4 years, 5 months ago (2016-07-07 02:23:41 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126713003/40001
4 years, 5 months ago (2016-07-07 02:24:51 UTC) #6
hayato
lgtm https://codereview.chromium.org/2126713003/diff/40001/third_party/WebKit/LayoutTests/shadow-dom/offsetParent-layoutObject-lifecycle.html File third_party/WebKit/LayoutTests/shadow-dom/offsetParent-layoutObject-lifecycle.html (right): https://codereview.chromium.org/2126713003/diff/40001/third_party/WebKit/LayoutTests/shadow-dom/offsetParent-layoutObject-lifecycle.html#newcode1 third_party/WebKit/LayoutTests/shadow-dom/offsetParent-layoutObject-lifecycle.html:1: <!DOCTYPE html> Could you move this file to ...
4 years, 5 months ago (2016-07-07 03:27:19 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-07 03:36:41 UTC) #9
kochi
Thanks for the review! https://codereview.chromium.org/2126713003/diff/40001/third_party/WebKit/LayoutTests/shadow-dom/offsetParent-layoutObject-lifecycle.html File third_party/WebKit/LayoutTests/shadow-dom/offsetParent-layoutObject-lifecycle.html (right): https://codereview.chromium.org/2126713003/diff/40001/third_party/WebKit/LayoutTests/shadow-dom/offsetParent-layoutObject-lifecycle.html#newcode1 third_party/WebKit/LayoutTests/shadow-dom/offsetParent-layoutObject-lifecycle.html:1: <!DOCTYPE html> On 2016/07/07 03:27:19, ...
4 years, 5 months ago (2016-07-07 03:39:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126713003/60001
4 years, 5 months ago (2016-07-07 03:40:10 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-07 05:07:31 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 05:09:24 UTC) #16
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/5c480f3117fe314b8cace4f33b84020e9e3424e2
Cr-Commit-Position: refs/heads/master@{#404081}

Powered by Google App Engine
This is Rietveld 408576698