Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1056)

Issue 2148043003: [Layout API] Fix layoutViewItem() null check in Element.cpp (Closed)

Created:
4 years, 5 months ago by pilgrim_google
Modified:
4 years, 5 months ago
Reviewers:
eae, jsbell
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, dgrogan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Layout API] Fix layoutViewItem() null check in Element.cpp There are two instances where we are creating a LayoutViewItem and incorrectly checking whether the underlying layout view is null. At this stage of the block layout API, the correct way is to call the isNull() method; checking whether the layoutViewItem object itself is null does not tell you whether the underlying layout view is null. BUG=499321 Committed: https://crrev.com/9e932c6f79609ca3163b40212835d37e8ff1a779 Cr-Commit-Position: refs/heads/master@{#405645}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M third_party/WebKit/Source/core/dom/Element.cpp View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
pilgrim_google
4 years, 5 months ago (2016-07-14 20:08:50 UTC) #4
eae
OK, LGTM
4 years, 5 months ago (2016-07-14 22:02:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2148043003/1
4 years, 5 months ago (2016-07-15 00:10:03 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 00:15:52 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-15 00:15:55 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 00:17:55 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9e932c6f79609ca3163b40212835d37e8ff1a779
Cr-Commit-Position: refs/heads/master@{#405645}

Powered by Google App Engine
This is Rietveld 408576698