third_party/WebKit/Source/core/dom/Element.cpp - Issue 2148043003: [Layout API] Fix layoutViewItem() null check in Element.cpp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 2148043003: [Layout API] Fix layoutViewItem() null check in Element.cpp (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/dom/Element.cpp

diff --git a/third_party/WebKit/Source/core/dom/Element.cpp b/third_party/WebKit/Source/core/dom/Element.cpp

index b35cf9138e2167da918498afdff7768617eb222b..78f59bda6740407c1a9c4d3d302abbd06dcf6338 100644

--- a/third_party/WebKit/Source/core/dom/Element.cpp

+++ b/third_party/WebKit/Source/core/dom/Element.cpp

@@ -689,7 +689,8 @@ int Element::clientWidth()

bool inQuirksMode = document().inQuirksMode();

if ((!inQuirksMode && document().documentElement() == this)

|| (inQuirksMode && isHTMLElement() && document().body() == this)) {

- if (LayoutViewItem layoutView = LayoutViewItem(document().layoutView())) {

+ LayoutViewItem layoutView = document().layoutViewItem();

+ if (!layoutView.isNull()) {

if (!RuntimeEnabledFeatures::overlayScrollbarsEnabled() || !document().frame()->isLocalRoot())

document().updateStyleAndLayoutIgnorePendingStylesheetsForNode(this);

if (document().page()->settings().forceZeroLayoutHeight())

@@ -713,7 +714,8 @@ int Element::clientHeight()