Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 2148003002: Remove NoSafepointScope from Dart_IsolateData(Dart_Isolate). (Closed)

Created:
4 years, 5 months ago by rmacnak
Modified:
4 years, 5 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove NoSafepointScope from Dart_IsolateData(Dart_Isolate). May be called from a thread the VM doesn't know about. (In Flutter, the Mojo handle watcher.) R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/0aea34396b066a683e2bf3341d75988d4235afd9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M runtime/vm/dart_api_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 5 months ago (2016-07-13 17:46:12 UTC) #2
siva
lgtm
4 years, 5 months ago (2016-07-13 21:26:09 UTC) #3
rmacnak
4 years, 5 months ago (2016-07-13 21:42:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0aea34396b066a683e2bf3341d75988d4235afd9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698