Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Side by Side Diff: runtime/vm/dart_api_impl.cc

Issue 2148003002: Remove NoSafepointScope from Dart_IsolateData(Dart_Isolate). (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "include/dart_api.h" 5 #include "include/dart_api.h"
6 #include "include/dart_mirrors_api.h" 6 #include "include/dart_mirrors_api.h"
7 #include "include/dart_native_api.h" 7 #include "include/dart_native_api.h"
8 8
9 #include "platform/assert.h" 9 #include "platform/assert.h"
10 #include "lib/stacktrace.h" 10 #include "lib/stacktrace.h"
(...skipping 1307 matching lines...) Expand 10 before | Expand all | Expand 10 after
1318 DART_EXPORT void* Dart_CurrentIsolateData() { 1318 DART_EXPORT void* Dart_CurrentIsolateData() {
1319 Isolate* isolate = Isolate::Current(); 1319 Isolate* isolate = Isolate::Current();
1320 CHECK_ISOLATE(isolate); 1320 CHECK_ISOLATE(isolate);
1321 NoSafepointScope no_safepoint_scope; 1321 NoSafepointScope no_safepoint_scope;
1322 return isolate->init_callback_data(); 1322 return isolate->init_callback_data();
1323 } 1323 }
1324 1324
1325 1325
1326 DART_EXPORT void* Dart_IsolateData(Dart_Isolate isolate) { 1326 DART_EXPORT void* Dart_IsolateData(Dart_Isolate isolate) {
1327 if (isolate == NULL) { 1327 if (isolate == NULL) {
1328 FATAL1("%s expects argument 'isolate' to be non-null.", CURRENT_FUNC); 1328 FATAL1("%s expects argument 'isolate' to be non-null.", CURRENT_FUNC);
1329 } 1329 }
1330 // TODO(16615): Validate isolate parameter. 1330 // TODO(16615): Validate isolate parameter.
1331 NoSafepointScope no_safepoint_scope;
1332 Isolate* iso = reinterpret_cast<Isolate*>(isolate); 1331 Isolate* iso = reinterpret_cast<Isolate*>(isolate);
1333 return iso->init_callback_data(); 1332 return iso->init_callback_data();
1334 } 1333 }
1335 1334
1336 1335
1337 DART_EXPORT Dart_Handle Dart_DebugName() { 1336 DART_EXPORT Dart_Handle Dart_DebugName() {
1338 DARTSCOPE(Thread::Current()); 1337 DARTSCOPE(Thread::Current());
1339 Isolate* I = T->isolate(); 1338 Isolate* I = T->isolate();
1340 return Api::NewHandle(T, String::New(I->name())); 1339 return Api::NewHandle(T, String::New(I->name()));
1341 } 1340 }
(...skipping 5132 matching lines...) Expand 10 before | Expand all | Expand 10 after
6474 6473
6475 DART_EXPORT bool Dart_IsPrecompiledRuntime() { 6474 DART_EXPORT bool Dart_IsPrecompiledRuntime() {
6476 #if defined(DART_PRECOMPILED_RUNTIME) 6475 #if defined(DART_PRECOMPILED_RUNTIME)
6477 return true; 6476 return true;
6478 #else 6477 #else
6479 return false; 6478 return false;
6480 #endif 6479 #endif
6481 } 6480 }
6482 6481
6483 } // namespace dart 6482 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698