Fix password detail dialog so it doesn't imply save functionality.

Fix password detail dialog so it doesn't imply save functionality.

Added screenshots in bug.

BUG=620004
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/4d3d99d91597627eb5b2bd6f13d4c89b2bb4352a
Cr-Commit-Position: refs/heads/master@{#406079}

[hcarmona, 2016-07-13 19:01:49]

Description was changed from

==========
Fix password detail dialog so it doesn't imply save functionality.

BUG=620004
==========

to

==========
Fix password detail dialog so it doesn't imply save functionality.

BUG=620004
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[hcarmona, 2016-07-13 23:22:37]

hcarmona@chromium.org changed reviewers:
+ tommycli@chromium.org

[hcarmona, 2016-07-13 23:22:38]

PTAL

[hcarmona, 2016-07-15 18:28:08]

Friendly ping on this CL.

[hcarmona, 2016-07-15 18:48:50]

Description was changed from

==========
Fix password detail dialog so it doesn't imply save functionality.

BUG=620004
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix password detail dialog so it doesn't imply save functionality.

Added screenshots in bug.

BUG=620004
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2016-07-15 18:52:29]

lgtm sans nit

https://codereview.chromium.org/2147933004/diff/1/chrome/app/settings_strings...
File chrome/app/settings_strings.grdp (right):

https://codereview.chromium.org/2147933004/diff/1/chrome/app/settings_strings...
chrome/app/settings_strings.grdp:296: <message name="IDS_SETTINGS_PASSWORD_DONE"
desc="Label for a button that dismisses the password details dialog.">
Nit: Should this be re-ordered below "Saved password details"?

And in the .cc file also?

[hcarmona, 2016-07-15 18:59:11]

The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 18:59:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 18:59:46]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
     tryserver.chromium.linux
   For more details, see http://crbug.com/617627.

[commit-bot: I haz the power, 2016-07-15 19:03:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 19:03:02]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[hcarmona, 2016-07-15 19:03:48]

https://codereview.chromium.org/2147933004/diff/1/chrome/app/settings_strings...
File chrome/app/settings_strings.grdp (right):

https://codereview.chromium.org/2147933004/diff/1/chrome/app/settings_strings...
chrome/app/settings_strings.grdp:296: <message name="IDS_SETTINGS_PASSWORD_DONE"
desc="Label for a button that dismisses the password details dialog.">
On 2016/07/15 18:52:29, tommycli wrote:
> Nit: Should this be re-ordered below "Saved password details"?
> 
> And in the .cc file also?

No objections. Done.

[hcarmona, 2016-07-15 21:18:37]

Description was changed from

==========
Fix password detail dialog so it doesn't imply save functionality.

Added screenshots in bug.

BUG=620004
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix password detail dialog so it doesn't imply save functionality.

Added screenshots in bug.

BUG=620004
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation
==========

[hcarmona, 2016-07-15 21:18:41]

The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 21:19:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 21:19:59]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
     tryserver.chromium.linux
   For more details, see http://crbug.com/617627.

[commit-bot: I haz the power, 2016-07-15 23:03:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 23:03:38]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[hcarmona, 2016-07-18 18:16:58]

Description was changed from

==========
Fix password detail dialog so it doesn't imply save functionality.

Added screenshots in bug.

BUG=620004
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix password detail dialog so it doesn't imply save functionality.

Added screenshots in bug.

BUG=620004
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[hcarmona, 2016-07-18 18:17:06]

The CQ bit was checked by hcarmona@chromium.org

[hcarmona, 2016-07-18 18:17:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
tommycli@chromium.org
Link to the patchset: https://codereview.chromium.org/2147933004/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-07-18 18:17:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 20:13:03]

Description was changed from

==========
Fix password detail dialog so it doesn't imply save functionality.

Added screenshots in bug.

BUG=620004
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix password detail dialog so it doesn't imply save functionality.

Added screenshots in bug.

BUG=620004
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-07-18 20:13:04]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-18 20:13:07]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-18 20:15:38]

Description was changed from

==========
Fix password detail dialog so it doesn't imply save functionality.

Added screenshots in bug.

BUG=620004
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix password detail dialog so it doesn't imply save functionality.

Added screenshots in bug.

BUG=620004
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/4d3d99d91597627eb5b2bd6f13d4c89b2bb4352a
Cr-Commit-Position: refs/heads/master@{#406079}
==========

[commit-bot: I haz the power, 2016-07-18 20:15:40]

Patchset 3 (id:??) landed as
https://crrev.com/4d3d99d91597627eb5b2bd6f13d4c89b2bb4352a
Cr-Commit-Position: refs/heads/master@{#406079}