chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html - Issue 2147933004: Fix password detail dialog so it doesn't imply save functionality.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html

Issue 2147933004: Fix password detail dialog so it doesn't imply save functionality. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/app/settings_strings.grdp ('k') | chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html

diff --git a/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html b/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html

index 366d04dd9842b4b8ab34955bd73c358d6989a85c..0c2c11091dec370daa80e9a638b6057bf7ec598b 100644

--- a/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html

+++ b/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html

@@ -23,19 +23,19 @@

}

</style>

<cr-dialog id="dialog">

- <div class="title">$i18n{editPasswordTitle}</div>

+ <div class="title">$i18n{passwordDetailsTitle}</div>

<paper-input id="websiteInput" label="$i18n{editPasswordWebsiteLabel}"

- value="[[item.loginPair.originUrl]]">

+ value="[[item.loginPair.originUrl]]" readonly>

</paper-input>

<paper-input id="usernameInput" label="$i18n{editPasswordUsernameLabel}"

- value="[[item.loginPair.username]]">

+ value="[[item.loginPair.username]]" readonly>

</paper-input>

<paper-input id="passwordInput"

label="$i18n{editPasswordPasswordLabel}"

type="[[getPasswordInputType_(password)]]"

- value="[[getPassword_(item, password)]]">

+ value="[[getPassword_(item, password)]]" readonly>

</paper-input>

<paper-icon-button id="showPasswordButton"

icon="settings:visibility" on-tap="onShowPasswordButtonTap_">

@@ -44,9 +44,7 @@

</div>

<paper-button id="cancelButton"

- on-tap="onCancelButtonTap_">$i18n{cancel}</paper-button>

- <paper-button id="saveButton" class="action-button"

- on-tap="onSaveButtonTap_">$i18n{save}</paper-button>

+ on-tap="onCancelButtonTap_">$i18n{passwordsDone}</paper-button>

</div>

</cr-dialog>

</template>