Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2147883002: MIPS64: Implement Mips64And32, Mips64Or32, Mips64Nor32 and Mips64Xor32 operators. (Closed)

Created:
4 years, 5 months ago by Marija Antic
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Implement Mips64And32, Mips64Or32, Mips64Nor32 and Mips64Xor32 operators. If operands are loaded as unsigned 32-bit integer, they need to be sign extended to 64 bits. TEST=cctest/test-run-machops/RunWord32AndAndWord32ShrP, cctest/test-run-machops/RunWord32OrP, cctest/test-run-machops/RunWord32ShrP, cctest/test-run-machops/RunWord32XorP BUG= Committed: https://crrev.com/edf8c03547bb46247cbcdda2152a5e6e105b8ae8 Cr-Commit-Position: refs/heads/master@{#37705}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -14 lines) Patch
M src/compiler/mips64/code-generator-mips64.cc View 2 chunks +41 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-codes-mips64.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 4 chunks +5 lines, -5 lines 0 comments Download
M test/unittests/compiler/mips64/instruction-selector-mips64-unittest.cc View 5 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Marija Antic
PTAL
4 years, 5 months ago (2016-07-13 07:44:11 UTC) #2
balazs.kilvady
lgtm with nits: https://codereview.chromium.org/2147883002/diff/1/src/compiler/mips64/instruction-selector-mips64.cc File src/compiler/mips64/instruction-selector-mips64.cc (right): https://codereview.chromium.org/2147883002/diff/1/src/compiler/mips64/instruction-selector-mips64.cc#newcode170 src/compiler/mips64/instruction-selector-mips64.cc:170: There are no newlines at other ...
4 years, 5 months ago (2016-07-13 08:21:28 UTC) #3
Marija Antic
https://codereview.chromium.org/2147883002/diff/1/src/compiler/mips64/instruction-selector-mips64.cc File src/compiler/mips64/instruction-selector-mips64.cc (right): https://codereview.chromium.org/2147883002/diff/1/src/compiler/mips64/instruction-selector-mips64.cc#newcode170 src/compiler/mips64/instruction-selector-mips64.cc:170: On 2016/07/13 08:21:28, balazs.kilvady wrote: > There are no ...
4 years, 5 months ago (2016-07-13 08:32:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147883002/20001
4 years, 5 months ago (2016-07-13 09:00:06 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-13 09:02:21 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 09:04:45 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/edf8c03547bb46247cbcdda2152a5e6e105b8ae8
Cr-Commit-Position: refs/heads/master@{#37705}

Powered by Google App Engine
This is Rietveld 408576698