Make loader lock new-allocated to avoid shutdown crash.

Make loader lock new-allocated to avoid shutdown crash.

Process::Exit does not do the normal shutdown procedure - this CL avoids
a crash in the static destructor of the loader info lock by making it
new-allocated.

Also remove --shutdown flag since the clean shutdown procedure is on by
default since a while now.

BUG=#26846
R=asiva@google.com, zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/63e3f4dc8b53cf2707412e473462988e2b8269b0

[Florian Schneider, 2016-07-12 23:56:09]

fschneider@google.com changed reviewers:
+ asiva@google.com, zra@google.com

[Florian Schneider, 2016-07-12 23:56:09]

@zra: Do you remember why Process_Exit does not do the clean shutdown procedure?

[siva, 2016-07-13 00:03:42]

LGTM but please wait for Zach's comment about whether he is ok with removing the
'do_vm_shutdown' flag.

[zra, 2016-07-13 14:47:54]

On 2016/07/12 23:56:09, Florian Schneider wrote:
> @zra: Do you remember why Process_Exit does not do the clean shutdown
procedure?

Supporting it would make thread pool shutdown a lot more complicated. Right now,
the code will deadlock if you try it. I believe there may have been other
problems as well, but that is the first thing that would have to be sorted out.

[zra, 2016-07-13 14:51:38]

flag removal lgtm

https://codereview.chromium.org/2147833002/diff/1/runtime/bin/loader.cc
File runtime/bin/loader.cc (right):

https://codereview.chromium.org/2147833002/diff/1/runtime/bin/loader.cc#newco...
runtime/bin/loader.cc:612: loader_infos_lock_ = new Mutex();
Can this be deleted in a Loader::Shutdown() call somewhere in Dart::Cleanup()?

[Florian Schneider, 2016-07-13 16:13:58]

https://codereview.chromium.org/2147833002/diff/1/runtime/bin/loader.cc
File runtime/bin/loader.cc (right):

https://codereview.chromium.org/2147833002/diff/1/runtime/bin/loader.cc#newco...
runtime/bin/loader.cc:612: loader_infos_lock_ = new Mutex();
On 2016/07/13 14:51:38, zra wrote:
> Can this be deleted in a Loader::Shutdown() call somewhere in Dart::Cleanup()?

It could be. But since it is in the embedder, and only called before they whole
VM exits, there's no leak - and it won't be called from Process::Exit either.

I'd rather don't delete, because then I don't have to worry about potential
use-after-free.

[zra, 2016-07-13 16:16:06]

https://codereview.chromium.org/2147833002/diff/1/runtime/bin/loader.cc
File runtime/bin/loader.cc (right):

https://codereview.chromium.org/2147833002/diff/1/runtime/bin/loader.cc#newco...
runtime/bin/loader.cc:612: loader_infos_lock_ = new Mutex();
On 2016/07/13 16:13:58, Florian Schneider wrote:
> On 2016/07/13 14:51:38, zra wrote:
> > Can this be deleted in a Loader::Shutdown() call somewhere in
Dart::Cleanup()?
> 
> It could be. But since it is in the embedder, and only called before they
whole
> VM exits, there's no leak - and it won't be called from Process::Exit either.
> 
> I'd rather don't delete, because then I don't have to worry about potential
> use-after-free.

sgtm. Didn't notice this was in bin/

[Florian Schneider, 2016-07-13 16:41:10]

Description was changed from

==========
Make loader lock new-allocated to avoid shutdown crash.

Process::Exit does not do the normal shutdown procedure - this CL avoids
a crash in the static destructor of the loader info lock by making it
new-allocated.

Also remove --shutdown flag since the clean shutdown procedure is on by
default since a while now.

BUG=#26846
==========

to

==========
Make loader lock new-allocated to avoid shutdown crash.

Process::Exit does not do the normal shutdown procedure - this CL avoids
a crash in the static destructor of the loader info lock by making it
new-allocated.

Also remove --shutdown flag since the clean shutdown procedure is on by
default since a while now.

BUG=#26846
R=asiva@google.com, zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/63e3f4dc8b53cf2707412e473462988e2b8269b0
==========

[Florian Schneider, 2016-07-13 16:41:11]

Committed patchset #1 (id:1) manually as
63e3f4dc8b53cf2707412e473462988e2b8269b0 (presubmit successful).