Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: runtime/vm/service_isolate.cc

Issue 2147833002: Make loader lock new-allocated to avoid shutdown crash. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/bin/loader.cc ('K') | « runtime/vm/dart.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service_isolate.cc
diff --git a/runtime/vm/service_isolate.cc b/runtime/vm/service_isolate.cc
index e85a5c03de1d191e77df65061718d8a0c78a6ecb..19ccf685da512528ab8a910740a524d7ae549fb2 100644
--- a/runtime/vm/service_isolate.cc
+++ b/runtime/vm/service_isolate.cc
@@ -23,8 +23,6 @@
namespace dart {
-DECLARE_FLAG(bool, shutdown);
-
#define Z (T->zone())
@@ -462,9 +460,6 @@ void ServiceIsolate::Run() {
void ServiceIsolate::KillServiceIsolate() {
- if (!FLAG_shutdown) {
- return;
- }
{
MonitorLocker ml(monitor_);
shutting_down_ = true;
« runtime/bin/loader.cc ('K') | « runtime/vm/dart.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698