|
|
Chromium Code Reviews|
Created:
4 years, 5 months ago by Sharu Jiang Modified:
4 years, 5 months ago CC:
martiniss, chromium-reviews, dnj, infra-reviews+infra_chromium.org Base URL:
https://chromium.googlesource.com/infra/infra.git@master Target Ref:
refs/heads/master Project:
infra Visibility:
Public. |
Description[Findit] Fix flaky dashboard test.
The tests are flaky because of the request_time for testing fracas analyses are not fixed, utcnow() is used for testing, so if the tests are running right pass the midnight of today, the assertion would fail. Fix this by hard-coding the request time of testcases and setting start_date and end_date in the request.
BUG=624998, 626511
Committed: https://chromium.googlesource.com/infra/infra/+/b6b2c25f84c821e3c20feb509c9d366ea30905f2
Patch Set 1 #
Messages
Total messages: 21 (16 generated)
Description was changed from ========== Fix flaky dashboard test. BUG= ========== to ========== [Findit] Fix flaky dashboard test. The tests are flaky because of the request_time for testing fracas analyses are not fixed, utcnow() is used for testing, so if the tests are running right pass the midnight of today, the assertion would fail. Fix this by fixing the request time to testcases and set start_date and end_date in the request. BUG=624998, 624998 ==========
katesonia@chromium.org changed reviewers: + stgao@chromium.org
PTAL :)
The CQ bit was checked by katesonia@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org to run a CQ dry run
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-infra-committers". Note that this has nothing to do with OWNERS files.
Patchset #1 (id:1) has been deleted
martiniss@chromium.org changed reviewers: + martiniss@chromium.org
lgtm
Description was changed from ========== [Findit] Fix flaky dashboard test. The tests are flaky because of the request_time for testing fracas analyses are not fixed, utcnow() is used for testing, so if the tests are running right pass the midnight of today, the assertion would fail. Fix this by fixing the request time to testcases and set start_date and end_date in the request. BUG=624998, 624998 ========== to ========== [Findit] Fix flaky dashboard test. The tests are flaky because of the request_time for testing fracas analyses are not fixed, utcnow() is used for testing, so if the tests are running right pass the midnight of today, the assertion would fail. Fix this by hard-coding the request time of testcases and setting start_date and end_date in the request. BUG=624998, 624998 ==========
The CQ bit was checked by katesonia@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [Findit] Fix flaky dashboard test. The tests are flaky because of the request_time for testing fracas analyses are not fixed, utcnow() is used for testing, so if the tests are running right pass the midnight of today, the assertion would fail. Fix this by hard-coding the request time of testcases and setting start_date and end_date in the request. BUG=624998, 624998 ========== to ========== [Findit] Fix flaky dashboard test. The tests are flaky because of the request_time for testing fracas analyses are not fixed, utcnow() is used for testing, so if the tests are running right pass the midnight of today, the assertion would fail. Fix this by hard-coding the request time of testcases and setting start_date and end_date in the request. BUG=624998, 626511 ==========
The CQ bit was unchecked by commit-bot@chromium.org to run a CQ dry run
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by katesonia@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Findit] Fix flaky dashboard test. The tests are flaky because of the request_time for testing fracas analyses are not fixed, utcnow() is used for testing, so if the tests are running right pass the midnight of today, the assertion would fail. Fix this by hard-coding the request time of testcases and setting start_date and end_date in the request. BUG=624998, 626511 ========== to ========== [Findit] Fix flaky dashboard test. The tests are flaky because of the request_time for testing fracas analyses are not fixed, utcnow() is used for testing, so if the tests are running right pass the midnight of today, the assertion would fail. Fix this by hard-coding the request time of testcases and setting start_date and end_date in the request. BUG=624998, 626511 Committed: https://chromium.googlesource.com/infra/infra/+/b6b2c25f84c821e3c20feb509c9d3... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/infra/infra/+/b6b2c25f84c821e3c20feb509c9d3...
Message was sent while issue was closed.
lgtm |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
