Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 2147773002: [Findit] Fix flaky dashboard test. (Closed)

Created:
4 years, 5 months ago by Sharu Jiang
Modified:
4 years, 5 months ago
Reviewers:
stgao, martiniss
CC:
martiniss, chromium-reviews, dnj, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

[Findit] Fix flaky dashboard test. The tests are flaky because of the request_time for testing fracas analyses are not fixed, utcnow() is used for testing, so if the tests are running right pass the midnight of today, the assertion would fail. Fix this by hard-coding the request time of testcases and setting start_date and end_date in the request. BUG=624998, 626511 Committed: https://chromium.googlesource.com/infra/infra/+/b6b2c25f84c821e3c20feb509c9d366ea30905f2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -34 lines) Patch
M appengine/findit/handlers/crash/test/fracas_dashboard_test.py View 10 chunks +28 lines, -34 lines 0 comments Download

Messages

Total messages: 21 (16 generated)
Sharu Jiang
PTAL :)
4 years, 5 months ago (2016-07-12 22:28:46 UTC) #3
martiniss
lgtm
4 years, 5 months ago (2016-07-12 23:36:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147773002/20001
4 years, 5 months ago (2016-07-12 23:59:23 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/infra/infra/+/b6b2c25f84c821e3c20feb509c9d366ea30905f2
4 years, 5 months ago (2016-07-13 00:11:11 UTC) #20
stgao
4 years, 5 months ago (2016-07-13 06:43:24 UTC) #21
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698